Move cifmw_basedir var to group_vars - part one #3451
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
recheck |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
danpawlik
force-pushed
the
OSPRH-20491-move-cifmw_data_dir
branch
from
24bfe97 to
214c377
Compare
danpawlik
changed the title
The `cifmw_basedir` variable is now expected to be defined group_vars. Previous fallback to `ansible_user_dir ~ '/ci-framework-data'` has been removed from playbooks and roles. This change ensures consistency across roles and prevents accidental use of a default path when `cifmw_basedir` is intentionally unset. Signed-off-by: Daniel Pawlik <[email protected]>
danpawlik
force-pushed
the
OSPRH-20491-move-cifmw_data_dir
branch
from
214c377 to
2290d71
Compare
danpawlik
requested review from
a team,
abays,
fmount and
fultonj
as code owners
|
Is there any possibility of encountering breaking errors when the cifmw_basedir is not defined? I see you mentioned there is cases where it is intentionally unset but how well are these cases handled? |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
The
cifmw_basedirvariable is now expected to be defined group_vars.Previous fallback to
ansible_user_dir ~ '/ci-framework-data'has beenremoved from playbooks and roles.
This change ensures consistency across roles and prevents accidental use
of a default path when
cifmw_basediris intentionally unset.This commit is one part of a set of changes.
NOTE:
Probably this commit would be split into few pull requests.