-
Notifications
You must be signed in to change notification settings - Fork 139
Test with logging into staging registry #3460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Test with logging into staging registry #3460
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
According to latest mail announcement this registry.stage.redhat.io is correct one now. |
ciecierski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change pull request title and name of tasks in the tasks file. Other than that it looks good to me.
|
If that is a test, converting into a draft, otherwise change commit message and be more verbose. Thanks |
sathlan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda make sense. But I agree that more context is needed. I guess that the cifmw_registry_token credential now points to staging instead of redhat cdn hence the change, but that should be clarified.
820a0d6 to
66ce614
Compare
|
So this shoudn't work and you should have: please confirm. Furthermore I think the right solution is to activate redirection here. Full working setup would be:
No need to rename the image. Those are what we use to setup the compute node with staging. |
sathlan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentionned in my comment I don't think this work (it should fail on signature verification) and is the right approach IMHO. We should use what we use on the edpm compute node: proxy registries setup and ignore signature.
Of course if changing the name just work, then I will reconsider ... please let me know.
For me doing the setup in the posted comment resolved the issue without changing the image name.
|
@sathlan I can confirm that my hybrid deployment is fully updating now with this image name change applied, but I also don't have a preference on how to unblock the updates job downstream. I can also test what you are recommending if that is the preferred route. |
|
Nice. I'm still wondering how does your deployment avoid the signature problem, do you know ? |
|
@sathlan this is just to pull an image on the initial controller correct? I was under the impression that was already configured to handle the staging registry in this instance. I can redeploy and autohold to inspect it's registry configuration to confirm. |
|
@jamepark4 you are correct, this login is to pull an image on the controller-0 |
|
@sathlan @ciecierski yea it's strange I can't yet find what's applying the configuration to controller-0 but I didn't need to add the insecure policy to get the update to progress. It appears to already have been present: I know downstream has some patches that add the policy to the computes, but I'm not using that in this deployment. |
Evaluating FR3 to FR4 updates on hybrid environments.