Add support for customizing install_yamls devsetup tool versions #3462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
dprince
force-pushed
the
install_yamls_devestup_vars
branch
from
c7b0d71 to
fa5695f
Compare
danpawlik
previously approved these changes
Nov 6, 2025
Contributor
|
I see that spell check does not pass, because |
dprince
force-pushed
the
install_yamls_devestup_vars
branch
from
fa5695f to
367cf3c
Compare
danpawlik
previously approved these changes
Nov 6, 2025
brjackma
previously approved these changes
Nov 6, 2025
Contributor
Author
|
/test images |
3 similar comments
Contributor
Author
|
/test images |
Contributor
Author
|
/test images |
Contributor
Author
|
/test images |
dprince
added a commit
to dprince/openstack-operator
that referenced
this pull request
Nov 6, 2025
This upgrades the operator-sdk to version 1.41.1, which includes migrating
to the Kubebuilder v4 layout and modernizing the project structure.
Key changes:
- Re-scaffold the project with operator-sdk 1.41.1
- Update both main.go to support the latest kubebuilder features. This
includes using WithAuthenticationAndAuthorization to guard metrics
endpoints. This drops use of kube-rbac-proxy for openstack-operator.
- Migrated from Kubebuilder v3 to v4 layout (PROJECT file updated)
- Renamed apis/ directory to api/ following Kubebuilder v4 conventions
- Updated all import paths throughout the codebase to use api/ instead of apis/
- Moved main.go to cmd/main.go per new project structure
- Partially updated webhook implementations to use new validation/defaulting patterns. More
work can be done to consolidate the webhook code in the internal/webhook directory in the future.
- Added missing webhook configurations for OpenStackClient, OpenStackDataPlaneService, and
OpenStackDataPlaneDeployment to PROJECT
- Upgraded kustomize from v5.5.0 to v5.6.0
- Updated controller-gen paths to reflect new directory structure
- Updated all Makefile targets and test paths
Co-Authored-By: Claude <[email protected]>
Depends-On: openstack-k8s-operators/ci-framework#3462
Jira: OSPRH-21438
Contributor
Author
|
/test images |
Contributor
Author
|
/test images |
dprince
force-pushed
the
install_yamls_devestup_vars
branch
from
367cf3c to
0d52e8d
Compare
dprince
force-pushed
the
install_yamls_devestup_vars
branch
from
0d52e8d to
0d80a23
Compare
This change introduces the ability to override default tool versions used by install_yamls devsetup. Users can now customize versions for: - OPM (cifmw_install_yamls_opm_version) - Operator SDK (cifmw_install_yamls_sdk_version) - Golang (cifmw_install_yamls_go_version) - Kustomize (cifmw_install_yamls_kustomize_version) The new customize_devsetup_vars.yml task updates the install_yamls devsetup/vars/default.yaml file when any of these variables are defined. Signed-off-by: Dan Prince <[email protected]>
dprince
force-pushed
the
install_yamls_devestup_vars
branch
from
0d80a23 to
1b3274e
Compare
michburk
approved these changes
Nov 7, 2025
amartyasinha
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the ability to override default tool versions used by install_yamls devsetup. Users can now customize versions for:
- OPM (cifmw_install_yamls_opm_version)
- Operator SDK (cifmw_install_yamls_sdk_version)
- Golang (cifmw_install_yamls_go_version)
- Kustomize (cifmw_install_yamls_kustomize_version)
The new customize_devsetup_vars.yml task updates the install_yamls devsetup/vars/default.yaml file when any of these variables are defined.