Skip to content

Conversation

@danpawlik
Copy link
Contributor

@danpawlik danpawlik commented Nov 12, 2025

Depends-On: #3479

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danpawlik danpawlik force-pushed the fix_subscription_installation branch 3 times, most recently from 8dcace0 to 547131a Compare November 12, 2025 17:41
@softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change #3479 is needed.

@danpawlik danpawlik force-pushed the fix_subscription_installation branch from 547131a to dc85a56 Compare November 12, 2025 17:43
@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 3478,dc85a56baf1ade788d449988a7e1e973cf571d73

@danpawlik danpawlik force-pushed the fix_subscription_installation branch from dc85a56 to e40b587 Compare November 12, 2025 17:48
@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 3478,e40b587050055827effacc5090c5b5b1e0bd5c3b

@danpawlik danpawlik force-pushed the fix_subscription_installation branch from e40b587 to 9fe97a5 Compare November 12, 2025 17:50
@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 3478,9fe97a5a0e025b8176279ab18f72e19d93fd3ed3

- Rename _cifmw_kustomize_deploy_olm_osp_operator_sub to
  _cifmw_kustomize_deploy_olm_osp_operator_subscription for better
  readability and consistency.

- Add dedicated cifmw_kustomize_deploy_retries_subscription parameter
  (default: 90) to allow independent configuration of Subscription vs
  InstallPlan retry timeouts.

- Fix task name from 'Wait for InstallPlan to be created' to
  'Wait for Subscription to be created' to correctly reflect what
  the task is actually waiting for.

- Update role README.md to document the new retries_subscription
  parameter in the Timeouts section.

This change improves maintainability by using more descriptive variable
names and properly separating concerns between Subscription and
InstallPlan wait operations.

Resolves: https://issues.redhat.com/browse/OSPCIX-1100
Assisted-By: Claude Code/claude-sonnet-4.5
Signed-off-by: Sergii Golovatiuk <[email protected]>
Signed-off-by: Daniel Pawlik <[email protected]>
@danpawlik danpawlik force-pushed the fix_subscription_installation branch from 9fe97a5 to eb297b0 Compare November 12, 2025 17:53
@softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change #3479 is needed.

@danpawlik danpawlik closed this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants