Update custom ca certs hook #3481
Open
+15
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The hook was supposed to create a secret with custom ca certs and also update the Openstack control-plane to use it. This approach has brought some issues with the control-plane restarting, so we want to change the approach to creating the secret only. The use of the secret will be done separately. Signed-off-by: Katarina Strenkova <[email protected]>
kstrenkova
force-pushed
the
update-custom-ca-hook
branch
from
b361165 to
bd8178b
Compare
evallesp
reviewed
Nov 13, 2025
| connection: local | ||
| vars: | ||
| _custom_ca_cert_filepath: "{{ custom_ca_cert_filepath | mandatory }}" | ||
| _custom_ca_cert_url: "{{ custom_ca_cert_url | mandatory }}" |
Contributor
There was a problem hiding this comment.
(non-blocking) question: Don't we want to maintain functionallity to slurp local ca_cert?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hook was supposed to create a secret with custom ca certs and also update the Openstack control-plane to use it. This approach has brought some issues with the control-plane restarting, so we want to change the approach to creating the secret only. The use of the secret will be done separately.