Skip to content

[os_must_gather] Increase must gather timeout; print error on timeout #3486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danpawlik merged 1 commit into from
Nov 18, 2025
Merged

[os_must_gather] Increase must gather timeout; print error on timeout #3486

danpawlik merged 1 commit into from
Nov 18, 2025

Conversation

@danpawlik
Copy link
Contributor

@danpawlik danpawlik commented Nov 17, 2025

It seems that 'oc adm must-gather' command in some CI jobs does not finish on time. This commit increase the timeout from default 12 minutes (cifmw_os_must_gather_timeout - 10 minutes + 120s) to 25 minutes. Also print message when timeout has killed the command.

@danpawlik danpawlik requested a review from a team as a code owner November 17, 2025 09:53
@danpawlik
[os_must_gather] Increase must gather timeout; print error on timeout
ed2742d 
It seems that 'oc adm must-gather' command in some CI jobs does not
finish on time. This commit increase the timeout from default 12 minutes
(cifmw_os_must_gather_timeout - 10 minutes + 120s) to 25 minutes.
Also print message when timeout has killed the command.

Signed-off-by: Daniel Pawlik <[email protected]>
@danpawlik danpawlik force-pushed the increase-timeout-time-must-gather branch from f36ba9f to ed2742d Compare November 17, 2025 09:54
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 17, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/11e6e65c296240d5ac074c7ee5ef0634

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 21s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 43s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 50s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 28s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 19s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 48s
✔️ build-push-container-cifmw-client SUCCESS in 16m 42s
❌ cifmw-molecule-os_must_gather RETRY_LIMIT in 13m 12s

@danpawlik
Copy link
Contributor Author

danpawlik commented Nov 17, 2025

recheck

fmount
fmount reviewed Nov 17, 2025
View reviewed changes
Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 17, 2025
@rebtoor
Copy link
Contributor

rebtoor commented Nov 17, 2025

/approve

@danpawlik danpawlik enabled auto-merge (rebase) November 17, 2025 14:17
@fmount
Copy link
Contributor

fmount commented Nov 17, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fmount, rebtoor

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hjensas
hjensas approved these changes Nov 17, 2025
View reviewed changes
@danpawlik danpawlik requested a review from fmount November 17, 2025 20:23
@danpawlik danpawlik disabled auto-merge November 17, 2025 20:23
@danpawlik danpawlik merged commit f970185 into openstack-k8s-operators:main Nov 18, 2025
7 checks passed
@danpawlik danpawlik deleted the increase-timeout-time-must-gather branch November 18, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rebtoor rebtoor rebtoor approved these changes

@hjensas hjensas hjensas approved these changes

@evallesp evallesp evallesp approved these changes

@fmount fmount Awaiting requested review from fmount

Assignees

@fmount fmount

Labels

lgtm Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@danpawlik @rebtoor @fmount @hjensas @evallesp