-
Notifications
You must be signed in to change notification settings - Fork 144
fix: Add OWNERS file to support Prow code review process #3489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rebtoor: 1 invalid OWNERS file
Details
In response to this:
This commit introduces an
OWNERSfile, symlinking to the existing.github/CODEOWNERS, to ensure compatibility with the Prow code review system. Prow relies on theOWNERSfile to manage reviewer and approver roles for PRs, as documented in the Kubernetes community guidelines:
https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#the-code-review-processWhile GitHub uses CODEOWNERS for native code review assignment, Prow requires the OWNERS file format for integration with its automation and review workflows. This change facilitates better automation and review processes for repositories utilizing Prow.
No changes to reviewer assignments or permissions are introduced—this only ensures that both GitHub and Prow-based systems function as intended.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rebtoor The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/lgtm |
|
New changes are detected. LGTM label has been removed. |
e93772a
Migrate from GitHub CODEOWNERS to Kubernetes-style OWNERS files to be coherent with the rest of the organization and the OpenShift org, as we are using Prow for CI automation. Changes: - Created root OWNERS file with default approvers - Created OWNERS files distributed across roles/, playbooks/, and scenarios/ - Added OWNERS_ALIASES file for centralized team management - Fixed check_k8s_snippets_comment.sh to exclude OWNERS files Ref: https://www.kubernetes.dev/docs/guide/owners/ Signed-off-by: Roberto Alfieri <[email protected]>
danpawlik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blind approve
Convert CODEOWNERS to Kubernetes OWNERS format
Migrate from GitHub CODEOWNERS to Kubernetes-style OWNERS files to be coherent with the rest of the organization and the OpenShift org, as we are using Prow for CI automation.
Changes:
Ref: https://www.kubernetes.dev/docs/guide/owners/