Skip to content

Conversation

@rebtoor
Copy link
Contributor

@rebtoor rebtoor commented Nov 17, 2025

Convert CODEOWNERS to Kubernetes OWNERS format

Migrate from GitHub CODEOWNERS to Kubernetes-style OWNERS files to be coherent with the rest of the organization and the OpenShift org, as we are using Prow for CI automation.

Changes:

  • Created root OWNERS file with default approvers
  • Created OWNERS files distributed across roles/, playbooks/, and scenarios/
  • Added OWNERS_ALIASES file for centralized team management
  • Fixed check_k8s_snippets_comment.sh to exclude OWNERS files

Ref: https://www.kubernetes.dev/docs/guide/owners/

Copy link
Contributor

@openshift-ci openshift-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rebtoor: 1 invalid OWNERS file

Details

In response to this:

This commit introduces an OWNERS file, symlinking to the existing .github/CODEOWNERS, to ensure compatibility with the Prow code review system. Prow relies on the OWNERS file to manage reviewer and approver roles for PRs, as documented in the Kubernetes community guidelines:
https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#the-code-review-process

While GitHub uses CODEOWNERS for native code review assignment, Prow requires the OWNERS file format for integration with its automation and review workflows. This change facilitates better automation and review processes for repositories utilizing Prow.

No changes to reviewer assignments or permissions are introduced—this only ensures that both GitHub and Prow-based systems function as intended.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rebtoor
Copy link
Contributor Author

rebtoor commented Nov 17, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rebtoor

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fmount
fmount previously approved these changes Nov 18, 2025
Valkyrie00
Valkyrie00 previously approved these changes Nov 18, 2025
@fmount
Copy link
Contributor

fmount commented Nov 19, 2025

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

New changes are detected. LGTM label has been removed.

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5c766c0741bb4e738beb1340286723f9

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 00m 04s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 31s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 42m 53s
✔️ cifmw-multinode-tempest SUCCESS in 1h 45m 44s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 39s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 48s
cifmw-pod-k8s-snippets-source FAILURE in 4m 45s
cifmw-pod-pre-commit FAILURE in 8m 02s
✔️ cifmw-architecture-validate-hci SUCCESS in 4m 21s
build-push-container-cifmw-client FAILURE in 6m 59s
✔️ cifmw-molecule-adoption_osp_deploy SUCCESS in 4m 13s
✔️ cifmw-molecule-ci_dcn_site SUCCESS in 2m 27s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 46s
✔️ cifmw-molecule-ci_local_storage SUCCESS in 10m 53s
✔️ cifmw-molecule-ci_lvms_storage SUCCESS in 2m 30s
✔️ cifmw-molecule-cifmw_block_device SUCCESS in 4m 55s
✔️ cifmw-molecule-cifmw_ceph_client SUCCESS in 4m 36s
✔️ cifmw-molecule-cifmw_ceph_spec SUCCESS in 4m 55s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 4m 47s
✔️ cifmw-molecule-cifmw_create_admin SUCCESS in 7m 41s
✔️ cifmw-molecule-compliance SUCCESS in 4m 08s
✔️ cifmw-molecule-federation SUCCESS in 2m 28s
✔️ cifmw-molecule-idrac_configuration SUCCESS in 3m 35s
✔️ cifmw-molecule-ipa SUCCESS in 2m 26s
✔️ cifmw-molecule-nat64_appliance SUCCESS in 15m 09s
✔️ cifmw-molecule-os_must_gather SUCCESS in 21m 49s
✔️ cifmw-molecule-polarion SUCCESS in 2m 26s
✔️ cifmw-molecule-reportportal SUCCESS in 3m 29s
✔️ cifmw-molecule-shiftstack SUCCESS in 13m 09s
✔️ cifmw-molecule-switch_config SUCCESS in 2m 30s
✔️ cifmw-molecule-tempest SUCCESS in 5m 17s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 34s
✔️ cifmw-molecule-tofu SUCCESS in 8m 02s
✔️ cifmw-molecule-update SUCCESS in 5m 09s
✔️ cifmw-molecule-validations SUCCESS in 4m 39s

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/81862cbadaad4d629d34c3b80408e6ad

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 04m 36s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 35s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 33m 26s
✔️ cifmw-multinode-tempest SUCCESS in 1h 46m 44s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 09s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 31s
cifmw-pod-k8s-snippets-source FAILURE in 4m 39s
cifmw-pod-pre-commit FAILURE in 8m 03s
✔️ cifmw-architecture-validate-hci SUCCESS in 4m 22s
✔️ build-push-container-cifmw-client SUCCESS in 21m 02s
✔️ cifmw-molecule-adoption_osp_deploy SUCCESS in 3m 56s
✔️ cifmw-molecule-ci_dcn_site SUCCESS in 2m 28s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 31s
✔️ cifmw-molecule-ci_local_storage SUCCESS in 10m 57s
✔️ cifmw-molecule-ci_lvms_storage SUCCESS in 2m 45s
✔️ cifmw-molecule-cifmw_block_device SUCCESS in 4m 48s
✔️ cifmw-molecule-cifmw_ceph_client SUCCESS in 4m 27s
✔️ cifmw-molecule-cifmw_ceph_spec SUCCESS in 4m 39s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 5m 00s
✔️ cifmw-molecule-cifmw_create_admin SUCCESS in 7m 29s
✔️ cifmw-molecule-compliance SUCCESS in 4m 09s
✔️ cifmw-molecule-federation SUCCESS in 2m 34s
✔️ cifmw-molecule-idrac_configuration SUCCESS in 3m 38s
✔️ cifmw-molecule-ipa SUCCESS in 2m 24s
✔️ cifmw-molecule-nat64_appliance SUCCESS in 16m 31s
✔️ cifmw-molecule-os_must_gather SUCCESS in 25m 05s
✔️ cifmw-molecule-polarion SUCCESS in 2m 33s
✔️ cifmw-molecule-reportportal SUCCESS in 3m 26s
✔️ cifmw-molecule-shiftstack SUCCESS in 13m 49s
✔️ cifmw-molecule-switch_config SUCCESS in 2m 47s
✔️ cifmw-molecule-tempest SUCCESS in 5m 17s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 50s
✔️ cifmw-molecule-tofu SUCCESS in 7m 45s
✔️ cifmw-molecule-update SUCCESS in 5m 37s
✔️ cifmw-molecule-validations SUCCESS in 4m 44s

ciecierski
ciecierski previously approved these changes Nov 20, 2025
jistr
jistr previously approved these changes Nov 20, 2025
Migrate from GitHub CODEOWNERS to Kubernetes-style OWNERS files
to be coherent with the rest of the organization and the OpenShift
org, as we are using Prow for CI automation.

Changes:
- Created root OWNERS file with default approvers
- Created OWNERS files distributed across roles/, playbooks/, and scenarios/
- Added OWNERS_ALIASES file for centralized team management
- Fixed check_k8s_snippets_comment.sh to exclude OWNERS files

Ref: https://www.kubernetes.dev/docs/guide/owners/

Signed-off-by: Roberto Alfieri <[email protected]>
Copy link
Contributor

@danpawlik danpawlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blind approve

@rebtoor rebtoor merged commit 7ba5419 into openstack-k8s-operators:main Nov 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants