[update] Fix IPv6 nameserver support in workload launch script #3498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workload launch script fails on IPv6-only RHOSO deployments because it uses an IPv4-only regex to extract nameservers from `/etc/resolv.conf`. This causes subnet creation to fail when only IPv6 nameservers are available. Replace the regex approach with `awk`-based parsing that: - Supports both IPv4 and IPv6 addresses automatically - Only parses actual `nameserver` lines (ignores comments) - Collects all nameservers for redundancy - Provides public DNS fallback if no nameservers found - Maintains backward compatibility Closes: [OSPCIX-1114](https://issues.redhat.com/browse/OSPCIX-1114)
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
hjensas
reviewed
Nov 25, 2025
| done | ||
| else | ||
| echo "Warning: No nameservers found, using public DNS fallback" | ||
| DNS_ARGS="--dns-nameserver 8.8.8.8 --dns-nameserver 2001:4860:4860::8888" |
Contributor
There was a problem hiding this comment.
No need to set an IPv6 dns nameserver for an IPv4 subnet. (I think it might fail validation?)
|
This PR is stale because it has been for over 15 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workload launch script fails on IPv6-only RHOSO deployments
because it uses an IPv4-only regex to extract nameservers from
/etc/resolv.conf. This causes subnet creation to fail when only IPv6nameservers are available.
Replace the regex approach with
awk-based parsing that:nameserverlines (ignores comments)Closes: OSPCIX-1114