Skip to content

[update] Fix IPv6 nameserver support in workload launch script #3498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sathlan wants to merge 1 commit into from
Closed

[update] Fix IPv6 nameserver support in workload launch script #3498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions roles/update/templates/workload_launch.sh.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,19 @@ function workload_launch {
## create networking
openstack network list | grep ${TENANT_NET_NAME}
if [ $? -ne 0 ]; then
NAMESERVER=$(grep -Eo '[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}' /etc/resolv.conf | head -1)
# Collect all nameservers from resolv.conf
NAMESERVERS=$(awk '/^nameserver[[:space:]]/ {print $2}' /etc/resolv.conf)

# Build DNS arguments
DNS_ARGS=""
if [ -n "$NAMESERVERS" ]; then
for ns in $NAMESERVERS; do
DNS_ARGS="$DNS_ARGS --dns-nameserver $ns"
done
else
echo "Warning: No nameservers found, using public DNS fallback"
DNS_ARGS="--dns-nameserver 8.8.8.8 --dns-nameserver 2001:4860:4860::8888"
Copy link
Contributor

@hjensas hjensas Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to set an IPv6 dns nameserver for an IPv4 subnet. (I think it might fail validation?)

fi
echo "Creating router ${TENANT_NET_NAME}_router"
os_cmd router create ${TENANT_NET_NAME}_router

Expand All @@ -357,7 +369,7 @@ function workload_launch {
--subnet-range 192.168.0.0/24 \
--allocation-pool start=192.168.0.10,end=192.168.0.100 \
--gateway 192.168.0.254 \
--dns-nameserver ${NAMESERVER} \
$DNS_ARGS \
--network ${TENANT_NET_NAME} \
${TENANT_NET_NAME}_subnet

Expand Down
Loading