[krb_request] Do not use FQCN for krb_request module (exception) #3584
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
krb_request module is used in some DS zuul ci playbooks, and zuul runs restricted version of Ansible, thus FQCN call of module is not getting resolved. Making custom module with FQCN work there would require to make symlink of the entire cifmw collection there, which does not make sense. Better to have an exception for such usage. Signed-off-by: Amartya Sinha <[email protected]>
amartyasinha
force-pushed
the
exception_for_krb_request_fqcn
branch
from
f4c690e to
1a8dea7
Compare
There was a problem hiding this comment.
Saw the slack thread and it seems like this fix works, so I'm adding an approval here to try and get it fixed asap.
I do want to ask though, are you certain that your other changes don't also run into this 'restricted version of Ansible' issue? If we need to revert more it'd probably be better to get that done quickly rather than have people run into similar issues in a couple days, ping eod-cifmw, wait for a response and a patch, etc.
@michburk hey! 'Restricted ansible' issue will happen only when custom module from our cifmw collection is executed in a playbook by zuul executor. If you will go through our ci playbooks, they mainly do the setup kind of thing. After that, a separate process of ansible is executed in that ci playbook to run cifmw. In such cases, we won't face the issue. I'll consider this one as exception. One supporting example is the use of FQCN for crawl_n_mask module. It works fine because the task is executed through ansible. |
3 participants
krb_request module is used in some DS zuul ci playbooks, and zuul runs restricted version of Ansible, thus FQCN call of module is not getting resolved.
Making custom module with FQCN work there would require to make symlink of the entire cifmw collection there, which does not make sense. Better to have an exception for such usage.
Jira: https://issues.redhat.com/browse/OSPRH-24090