[pcp_metrics] improve exception handling in plot annotate function #3587
Conversation
Move datetime.strptime() call inside try/except block to properly catch parsing errors. Also add TypeError to handled exceptions for robustness against unexpected input types. Signed-off-by: Vito Castellano <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3ffd2b4cb0d94b839731b903ace420fe ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 21m 45s |
|
recheck |
3 participants
Problem
The
datetime.strptime()call was outside the try/except block, meaning that annotation lines with valid separators but malformed timestamps would crash the script instead of being skipped gracefully.Example of problematic input:
15-01-2024 10:30:00,123 | PLAY [Deploy]This line would pass the
split(" | ")but failstrptime()with an unhandledValueError.Solution
datetime.strptime()inside the existing try/except blockTypeErrorto handled exceptions for additional robustnessTesting
Verified exception behavior with various malformed inputs locally