Do not use FQCN for cephx_key module (exception) #3590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The way ceph playbook from ci-framework is used in adoption jobs needs custom modules to be called without FQCN (i.e. through relative path). Making custom module with FQCN work there would require to make symlink of the entire cifmw collection there, which does not make sense. Better to have an exception for such usage. Signed-off-by: Amartya Sinha <[email protected]>
amartyasinha
force-pushed
the
exception_for_cephx_key_fqcn
branch
from
2c9691a to
50086fe
Compare
amartyasinha
changed the title
eduolivares
approved these changes
Jan 7, 2026
evallesp
approved these changes
Jan 7, 2026
amartyasinha
merged commit 3af40cb
into
openstack-k8s-operators:main
7 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way ceph playbook from ci-framework is used in adoption jobs needs custom modules to be called without FQCN (i.e. through relative path).
Making custom module with FQCN work there would require to make symlink of the entire cifmw collection there, which does not make sense. Better to have an exception for such usage.