Makefile: Support http & insecure registry in opm #54
Conversation
In a previous patch we added the USE_TLS environmental variable to our Makefile to allow pushing to insecure local registries during development. This patch extends this functionality to support the catalog building as well, which is convenient when using the `registry` container image for local development. With podman/docker push using the VERIFY_TLS=false will not only disable the TLS verification but will also allow HTTP connections, which is not the case of the `opm` command. The `opm` command has 2 different options `--skip-tls-verify` and `--use-http`, so we'll use the existing `VERIFY_TLS` for the first and a new `USE_HTTP` for the second.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Akrog The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ple-update Update config sample for new format (service subset deployment)
|
@Akrog: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
In a previous patch we added the USE_TLS environmental variable to our Makefile to allow pushing to insecure local registries during development.
This patch extends this functionality to support the catalog building as well, which is convenient when using the
registrycontainer image for local development.With podman/docker push using the VERIFY_TLS=false will not only disable the TLS verification but will also allow HTTP connections, which is not the case of the
opmcommand.The
opmcommand has 2 different options--skip-tls-verifyand--use-http, so we'll use the existingVERIFY_TLSfor the first and a newUSE_HTTPfor the second.