Skip to content

Conversation

@stuggi
Copy link
Contributor

@stuggi stuggi commented Nov 13, 2025

This commit upgrades the cinder-operator to use Operator SDK version 1.41.1, with the following major changes:

Project Structure:

  • Move pkg/ packages to internal/ following Go best practices
  • Move controllers/ to internal/controller/ per new operator-sdk layout
  • Replace main.go with cmd/main.go
  • Add controller and webhook test suites

Configuration Updates:

  • Split certificate management into separate metrics and webhook certs
  • Add network policies for metrics and webhook traffic
  • Rename auth_proxy resources to metrics for clarity
  • Add admin RBAC roles for all CRD types (Cinder, CinderAPI, etc.)
  • Update manager deployment configuration and patches
  • Modernize kustomization configurations

Webhook Changes:

  • Add dedicated webhook implementation in internal/webhook/v1beta1/
  • Remove old CRD webhook and CA injection patches
  • Update webhook manifests and service configuration

Cleanup:

  • Remove obsolete config patches and overlays

Dependencies:

  • Update go.mod and go.sum for operator-sdk 1.41.1 dependencies

Jira: OSPRH-21923

Assisted-by: claude-4-sonnet

Depends-On: openstack-k8s-operators/openstack-operator#1683

@softwarefactory-project-zuul
Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo openstack-k8s-operators/cinder-operator on branch main. The
problem was:

mapping values are not allowed in this context
in "openstack-k8s-operators/cinder-operator/zuul.d/projects.yaml@main", line 7, column 17

@openshift-ci openshift-ci bot requested review from ASBishop and viroel November 13, 2025 11:49
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi stuggi force-pushed the operator_sdk_1.41.1 branch 3 times, most recently from 146d8ca to caffbde Compare November 13, 2025 12:07
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e823f713a40b42f2b15dc5f60afabfb3

openstack-k8s-operators-content-provider FAILURE in 12m 07s
⚠️ cinder-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ cinder-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

@stuggi stuggi force-pushed the operator_sdk_1.41.1 branch from caffbde to edf7b4b Compare November 13, 2025 13:51
@softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#1683 is needed.

@stuggi
Copy link
Contributor Author

stuggi commented Nov 13, 2025

recheck

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/18abf0d0bbf840f495734eba4fac2d36

openstack-k8s-operators-content-provider FAILURE in 14m 27s
⚠️ cinder-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ cinder-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

@stuggi
Copy link
Contributor Author

stuggi commented Nov 13, 2025

recheck

@stuggi stuggi force-pushed the operator_sdk_1.41.1 branch from edf7b4b to 7ee1996 Compare November 13, 2025 15:21
@softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/install_yamls#1110 is needed.

@stuggi
Copy link
Contributor Author

stuggi commented Nov 13, 2025

/retest

@stuggi
Copy link
Contributor Author

stuggi commented Nov 13, 2025

recheck

@softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#1683 is needed.

@stuggi
Copy link
Contributor Author

stuggi commented Nov 14, 2025

/retest

@stuggi
Copy link
Contributor Author

stuggi commented Nov 14, 2025

recheck

@stuggi stuggi force-pushed the operator_sdk_1.41.1 branch 2 times, most recently from 4611390 to 76e0694 Compare November 14, 2025 11:44
@stuggi stuggi force-pushed the operator_sdk_1.41.1 branch 3 times, most recently from 0f0db60 to eb16018 Compare November 14, 2025 15:02
This commit upgrades the cinder-operator to use Operator SDK version 1.41.1,
with the following major changes:

Project Structure:
- Move pkg/ packages to internal/ following Go best practices
- Move controllers/ to internal/controller/ per new operator-sdk layout
- Replace main.go with cmd/main.go
- Add controller and webhook test suites

Configuration Updates:
- Split certificate management into separate metrics and webhook certs
- Add network policies for metrics and webhook traffic
- Rename auth_proxy resources to metrics for clarity
- Add admin RBAC roles for all CRD types (Cinder, CinderAPI, etc.)
- Update manager deployment configuration and patches
- Modernize kustomization configurations

Webhook Changes:
- Add dedicated webhook implementation in internal/webhook/v1beta1/
- Remove old CRD webhook and CA injection patches
- Update webhook manifests and service configuration

Cleanup:
- Remove obsolete config patches and overlays

Dependencies:
- Update go.mod and go.sum for operator-sdk 1.41.1 dependencies

Jira: OSPRH-21923

Assisted-by: claude-4-sonnet
Signed-off-by: Martin Schuppert <[email protected]>
@stuggi stuggi force-pushed the operator_sdk_1.41.1 branch from eb16018 to d956863 Compare November 14, 2025 15:02
@softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#1683 is needed.

@stuggi
Copy link
Contributor Author

stuggi commented Nov 14, 2025

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants