Skip to content

Add cleanup task for non-adopted Nova compute services#1211

Closed
renjingxiao wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
renjingxiao:compute_cleanup
Closed

Add cleanup task for non-adopted Nova compute services#1211
renjingxiao wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
renjingxiao:compute_cleanup

Conversation

@renjingxiao
Copy link
Contributor

This adds a cleanup task that delete stale nova-compute services and orphaned resource providers from controllers that are not adopted as compute nodes.

Assisted-by: Claude Code Sonnet 4.5

@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ciecierski for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2026

Hi @renjingxiao. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jistr jistr requested a review from bogdando January 29, 2026 15:17
@jistr
Copy link
Contributor

jistr commented Jan 29, 2026

/ok-to-test

Should the test edit be reflected in documentation too?

{{ oc_header }}
alias openstack="oc exec -t openstackclient -- openstack"

${BASH_ALIASES[openstack]} resource provider list -f value -c uuid -c name | awk '$1 == $2 {print $1}' | while read UUID; do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this does something legitimate. Also according the docs, before deleting service records, we should disable them. Please reach out nova folks to confirm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review, added command to disable them first, also opened a thread in nova channel to discuss it

This adds a cleanup task that delete stale nova-compute services
and orphaned resource providers from controllers that are not
adopted as compute nodes.

Assisted-by: Claude Code Sonnet 4.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants