Add cleanup task for non-adopted Nova compute services#1211
Add cleanup task for non-adopted Nova compute services#1211renjingxiao wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @renjingxiao. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test Should the test edit be reflected in documentation too? |
| {{ oc_header }} | ||
| alias openstack="oc exec -t openstackclient -- openstack" | ||
|
|
||
| ${BASH_ALIASES[openstack]} resource provider list -f value -c uuid -c name | awk '$1 == $2 {print $1}' | while read UUID; do |
There was a problem hiding this comment.
I am not sure this does something legitimate. Also according the docs, before deleting service records, we should disable them. Please reach out nova folks to confirm
There was a problem hiding this comment.
Thank you for the review, added command to disable them first, also opened a thread in nova channel to discuss it
This adds a cleanup task that delete stale nova-compute services and orphaned resource providers from controllers that are not adopted as compute nodes. Assisted-by: Claude Code Sonnet 4.5
1f01159 to
6c969ff
Compare
This adds a cleanup task that delete stale nova-compute services and orphaned resource providers from controllers that are not adopted as compute nodes.
Assisted-by: Claude Code Sonnet 4.5