-
Notifications
You must be signed in to change notification settings - Fork 80
Revert "Multi-cell adoption" #878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/25975a8f2597427695d52e567781c44b ✔️ noop SUCCESS in 0s |
|
@jistr @karelyatin please hold on reverting. |
|
I figured now that the regression test https://review.rdoproject.org/r/c/testproject/+/56204 for adoption-multinode-to-crc-no-ceph only included https://review.rdoproject.org/r/c/rdo-jobs/+/55910 and not #517. So, it wasn't tested with that base RDO job used with periodic-internal-adoption-multinode-to-crc(-no)-ceph jobs. Unfortunately, that was my mistake again. We should revert |
|
But let me 1st try this fix #881 |
|
recheck |
bogdando
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not, the RDO testproject https://review.rdoproject.org/r/c/testproject/+/56204 has passed for the fix
the standalone job with ceph has passed as well (in the fix PR)
|
We're aiming for #881 |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ciecierski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need revert anymore. Bogdan proposed correct fix in #881
|
Closing. Problem resolved with #881 |
Below three commits are reverted:-
Revert "Retain host IPs on internalapi network"
This reverts commit 4a8d8f8.
Revert "Add edpmRoleServiceName value for tlsCerts"
This reverts commit bf38f3c.
Revert "Multi-cell adoption for remaining services"
This reverts commit 1f273c9.
Related-Issue: OSPCIX-759