Skip to content

Conversation

@karelyatin
Copy link
Contributor

@karelyatin karelyatin commented Mar 28, 2025

Below three commits are reverted:-
Revert "Retain host IPs on internalapi network"

This reverts commit 4a8d8f8.

Revert "Add edpmRoleServiceName value for tlsCerts"

This reverts commit bf38f3c.

Revert "Multi-cell adoption for remaining services"

This reverts commit 1f273c9.

Related-Issue: OSPCIX-759

Below three commits are reverted:-
Revert "Retain host IPs on internalapi network"

This reverts commit 4a8d8f8.

Revert "Add edpmRoleServiceName value for tlsCerts"

This reverts commit bf38f3c.

Revert "Multi-cell adoption for remaining services"

This reverts commit 1f273c9.

Related-Issue: OSPCIX-759
@openshift-ci
Copy link

openshift-ci bot commented Mar 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sathlan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karelyatin karelyatin mentioned this pull request Mar 28, 2025
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/25975a8f2597427695d52e567781c44b

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph FAILURE in 1h 45m 22s
adoption-standalone-to-crc-no-ceph FAILURE in 2h 14m 57s
✔️ adoption-docs-preview SUCCESS in 1m 17s

@bogdando bogdando requested a review from ciecierski March 28, 2025 11:58
@bogdando
Copy link
Contributor

@jistr @karelyatin please hold on reverting.
The blocked downstream jobs are supposed to use FR2 code, and the subj was merged for FR3/main only

@bogdando
Copy link
Contributor

I figured now that the regression test https://review.rdoproject.org/r/c/testproject/+/56204 for adoption-multinode-to-crc-no-ceph only included https://review.rdoproject.org/r/c/rdo-jobs/+/55910 and not #517. So, it wasn't tested with that base RDO job used with periodic-internal-adoption-multinode-to-crc(-no)-ceph jobs. Unfortunately, that was my mistake again. We should revert

@ciecierski ciecierski requested review from bogdando, holser and jistr March 28, 2025 13:22
@bogdando
Copy link
Contributor

But let me 1st try this fix #881
I will start a testproject

@ciecierski
Copy link
Contributor

recheck

Copy link
Contributor

@bogdando bogdando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not, the RDO testproject https://review.rdoproject.org/r/c/testproject/+/56204 has passed for the fix
the standalone job with ceph has passed as well (in the fix PR)

@jistr
Copy link
Contributor

jistr commented Apr 3, 2025

We're aiming for #881
/hold

@openshift-merge-robot
Copy link

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@ciecierski ciecierski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need revert anymore. Bogdan proposed correct fix in #881

@ciecierski
Copy link
Contributor

Closing. Problem resolved with #881

@ciecierski ciecierski closed this Apr 9, 2025
@karelyatin karelyatin deleted the OSPCIX-759 branch April 9, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants