feat: detect previous run of linux_system_roles

[dudy-duce]

Fix #820

Updated nmstate_tool.yml to mirror the os-net-config behavior:

• Check for a return-code marker at /var/lib/edpm-config/nmstate.returncode.
• Read it when present and use it (plus edpm_network_config_update) to decide whether to run nmstate.
• After running nmstate, write its return code into /var/lib/edpm-config/nmstate.returncode.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dudy-duce
Once this PR has been reviewed and has the lgtm label, please assign stuggi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @dudy-duce. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a422376e2a5e404b9e6a8c5033c40865

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 45m 00s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 25s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 28m 42s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 43s
✔️ cifmw-crc-podified-edpm-baremetal-bootc SUCCESS in 1h 29m 37s
✔️ noop SUCCESS in 0s
✔️ edpm-ansible-tempest-multinode SUCCESS in 1h 31m 08s
❌ adoption-standalone-to-crc-ceph-provider FAILURE in 58m 58s

[rabi]

Have you tested this? I don't think nmstate_result would contain the failure details for errors configuring networking connection profiles.. In cases there are errors executing the role, ansible would stop at the task and it won't execute task from L71.

[dudy-duce]

Yes it stop the task in case of linux_system_roles failure.
What do you suggest ? Assuming it's a success if we complete this include_role from the playbook?

[rabi]

If it reaches L71 then you've to assume it has configured the network. Though nmstate.returncode file would never have non zero value. But we can live with it I guess. There is probably no need to register and check the result.

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/18337c389cd843809f2030d99d5bbca7

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 19m 57s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 25s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 24m 24s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 09s
✔️ cifmw-crc-podified-edpm-baremetal-bootc SUCCESS in 1h 32m 09s
✔️ noop SUCCESS in 0s
✔️ edpm-ansible-tempest-multinode SUCCESS in 1h 30m 21s
❌ adoption-standalone-to-crc-ceph-provider FAILURE in 2h 04m 25s