Bootc no lai #857
Bootc no lai #857
Conversation
This change writes systemd files to etc instead of /usr/share along with adding support for Python libraries baked into the bootc image. Signed-off-by: Brendan Shephard <[email protected]>
This change moves the script we're using for the logs cronjob into the /var/lib/openstack/cron directory. This facilitates the bootc immutable filesystem where we can't write to /usr, while also consolidating scripts relevant to our deployment in a common place. Signed-off-by: Brendan Shephard <[email protected]>
Signed-off-by: Brendan Shephard <[email protected]>
This change skips any calls to dnf on bootc nodes since they are expected to fail. Signed-off-by: Brendan Shephard <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
slagle
left a comment
slagle
left a comment
There was a problem hiding this comment.
- The edpm_kernel tasks from playbooks/bootstrap.yml need to be skipped as they are in the other PR.
- edpm_tuned needs to skip the package installs
- /etc/localtime is missing in the bootc image. we could have edpm_timezone create it.
| - 'edpm-container-shutdown' | ||
| - 'edpm-start-podman-container' | ||
| - name: "Create /usr/lib/systemd/system/edpm-container-shutdown.service" | ||
| when: not edpm_use_bootc |
There was a problem hiding this comment.
we'll need to do this even for bootc, unless we want to add it to the image build instead.
There was a problem hiding this comment.
Yeah, if we want to write them to /var/local then we can drop this.
Looks like I didn't update that commit with the new variable name anyway
| delay: "{{ edpm_libvirt_download_delay }}" | ||
| notify: | ||
| - Restart libvirt | ||
| when: not ansible_local.bootc |
There was a problem hiding this comment.
We need to install all these packages in the image don't we?
There was a problem hiding this comment.
Yeah, I had a few package related changes in my Containerfile:
https://github.com/openstack-k8s-operators/edpm-image-builder/pull/39/files#diff-20143ae4d38840b7744728ec7c6720a7891a112cabf4fe01bf9d109deff67788R22-R23
Among others, like python-pyroute2 was also required for os-net-config for example.
|
I've addressed all my comments in a new PR: #858 I've included your commits from this PR there as well. We can collaborate on either PR, doesn't matter to me, but I didn't want to push all my commits to your private branch without checking with you first. There are also some fixes to edpm-image-builder I used: With all of that together, I got a successful deployment. |
2 participants
No description provided.