-
Notifications
You must be signed in to change notification settings - Fork 86
Bootc no lai #857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootc no lai #857
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,7 @@ | |
| delay: "{{ edpm_libvirt_download_delay }}" | ||
| notify: | ||
| - Restart libvirt | ||
| when: not ansible_local.bootc | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to install all these packages in the image don't we?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, I had a few package related changes in my Containerfile: Among others, like |
||
|
|
||
| - name: Ensure monolithic libvirt and tcp socket activation is not enabled or running | ||
| tags: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,3 +29,4 @@ | |
| ansible.builtin.package: | ||
| name: nvme-cli | ||
| state: present | ||
| when: not ansible_local.bootc | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll need to do this even for bootc, unless we want to add it to the image build instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, if we want to write them to
/var/localthen we can drop this.Looks like I didn't update that commit with the new variable name anyway