Skip to content

Conversation

@amartyasinha
Copy link
Contributor

Due to some race condition, FQDN check is running before dnsmasq is returning FQDN for compute nodes. To avoid that, we want that this check should retry for couple of minutes until dnsmasq is ready and returns FQDN.

Ref: openstack-k8s-operators/architecture#595

@openshift-ci openshift-ci bot requested review from lewisdenny and slagle August 6, 2025 09:55
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amartyasinha
Once this PR has been reviewed and has the lgtm label, please assign stuggi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Due to some race condition, FQDN check is running before dnsmasq is returning FQDN for compute nodes. To avoid that, we want that this check should retry for couple of minutes until dnsmasq is ready and returns FQDN.

Ref: openstack-k8s-operators/architecture#595
rescue:
- name: Fail if hostname is not FQDN
ansible.builtin.fail:
msg: "{{ hostname.stdout }} does not contain . and does not appear to be an FQDN."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add delays/retries when we aren't sure what we're delaying for. Do we have enough debug information to tell what the missing configuration actually was? If not, perhaps we can add some debug tasks to show that (e.g., can't actually reach DNS, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants