Skip to content

Conversation

@fmount
Copy link
Contributor

@fmount fmount commented Oct 2, 2025

  • Add style-check target to Makefile using golang.org/x/tools/gopls/internal/analysis/modernize
  • Add pre-commit hook to automatically run style checks on commits

Benefits:

  • Ensures consistent code style across the codebase
  • Automatically applies modern Go idioms and best practices
  • Catches style issues early in the development process
  • Maintains code quality and readability standards
  • Reduces review overhead by automating style enforcement

Co-Authored-By: Claude [email protected]

- Add 'style-check' target to Makefile using golang.org/x/tools/gopls/internal/analysis/modernize
- Add pre-commit hook to automatically run style checks on commits

Benefits:
- Ensures consistent code style across the codebase
- Automatically applies modern Go idioms and best practices
- Catches style issues early in the development process
- Maintains code quality and readability standards
- Reduces review overhead by automating style enforcement

Co-Authored-By: Claude [email protected]
Signed-off-by: Francesco Pantano <[email protected]>
@fmount fmount requested review from abays, gibizer and stuggi October 2, 2025 08:56
@openshift-ci openshift-ci bot requested review from fultonj and viroel October 2, 2025 08:56
@fmount fmount requested review from SeanMooney and dprince and removed request for fultonj and viroel October 2, 2025 08:56
@openshift-ci openshift-ci bot added the approved label Oct 2, 2025
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 2, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abays
Copy link
Contributor

abays commented Oct 2, 2025

@fmount: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/glance-operator-build-kuttl 4e78833 link true /test glance-operator-build-kuttl

Full PR test history. Your PR dashboard.

{  failed to wait for the created cluster claim to become ready: timed out waiting for the condition}

/test glance-operator-build-kuttl

go vet ./... ./api/...

.PHONY: style-check
style-check: ## Run go modernize to check latest style conventions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its only a nit but i woudl proably have gone with modernize

as the make target name

mainly be cause i think for go format when i think if style checks but that is jsut me.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants