Skip to content

Conversation

@mcgonago
Copy link
Contributor

@mcgonago mcgonago commented Jul 28, 2025

Add/Set LimitRequestBody parameter to 10G

This is to get around the 1G limit [1]

[1] https://access.redhat.com/articles/6975397

Jira: https://issues.redhat.com/browse/OSPRH-17359

@openshift-ci openshift-ci bot requested review from fmount and olliewalsh July 28, 2025 14:49
@stuggi
Copy link
Contributor

stuggi commented Jul 28, 2025

@mcgonago maybe I should rebase #402 that you can customize the vhost? we have the same landed in keystone to configure OIDC Federation settings. openstack-k8s-operators/keystone-operator#525

@mcgonago
Copy link
Contributor Author

I tested this patch and see LimitRequestBody 10737418240 showing up in the right place in /etc/httpd/conf/httpd.conf

ServerTokens Prod
ServerSignature Off
TraceEnable Off
.
.
.
<VirtualHost *:8443>
  ## Vhost docroot
  DocumentRoot "/var/www/"
  .
  .
  .
  ## WSGI configuration
  WSGIApplicationGroup %{GLOBAL}
  WSGIDaemonProcess apache display-name=horizon group=apache processes=4 threads=1 user=apache
  WSGIProcessGroup apache
  WSGIScriptAlias /dashboard "/usr/share/openstack-dashboard/openstack_dashboard/wsgi.py"

  ## Extend LimitReqeustBody to 10GB
  LimitRequestBody 10737418240
</VirtualHost>

@stuggi
Copy link
Contributor

stuggi commented Jul 30, 2025

If the idea is to set the LimitRequestBody to a fixed const, why not just add it to https://github.com/openstack-k8s-operators/horizon-operator/blob/main/templates/horizon/config/httpd.conf ?

I have rebased #402, please have a look, which would be adding the same approach to horizon to be able to customize the httpd vhost.

@mcgonago
Copy link
Contributor Author

@stuggi - good point. I updated the changes to only have the setting in httpd.conf

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mcgonago, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi
Copy link
Contributor

stuggi commented Jul 31, 2025

/cherry-pick 18.0-fr3

@openshift-cherrypick-robot

@stuggi: once the present PR merges, I will cherry-pick it on top of 18.0-fr3 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick 18.0-fr3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 74f0a4b into openstack-k8s-operators:main Jul 31, 2025
8 checks passed
@openshift-cherrypick-robot

@stuggi: new pull request created: #486

Details

In response to this:

/cherry-pick 18.0-fr3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants