-
Notifications
You must be signed in to change notification settings - Fork 32
add/setLimitRequestBody parameter to 10G #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add/setLimitRequestBody parameter to 10G #485
Conversation
|
@mcgonago maybe I should rebase #402 that you can customize the vhost? we have the same landed in keystone to configure OIDC Federation settings. openstack-k8s-operators/keystone-operator#525 |
|
I tested this patch and see LimitRequestBody 10737418240 showing up in the right place in /etc/httpd/conf/httpd.conf ServerTokens Prod
ServerSignature Off
TraceEnable Off
.
.
.
<VirtualHost *:8443>
## Vhost docroot
DocumentRoot "/var/www/"
.
.
.
## WSGI configuration
WSGIApplicationGroup %{GLOBAL}
WSGIDaemonProcess apache display-name=horizon group=apache processes=4 threads=1 user=apache
WSGIProcessGroup apache
WSGIScriptAlias /dashboard "/usr/share/openstack-dashboard/openstack_dashboard/wsgi.py"
## Extend LimitReqeustBody to 10GB
LimitRequestBody 10737418240
</VirtualHost> |
|
If the idea is to set the I have rebased #402, please have a look, which would be adding the same approach to horizon to be able to customize the httpd vhost. |
|
@stuggi - good point. I updated the changes to only have the setting in httpd.conf |
stuggi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mcgonago, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick 18.0-fr3 |
|
@stuggi: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
74f0a4b
into
openstack-k8s-operators:main
|
@stuggi: new pull request created: #486 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add/Set LimitRequestBody parameter to 10G
This is to get around the 1G limit [1]
[1] https://access.redhat.com/articles/6975397
Jira: https://issues.redhat.com/browse/OSPRH-17359