-
Notifications
You must be signed in to change notification settings - Fork 32
Use lib-common DownwardAPI to retrieve pod IP #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bshephar The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @bshephar. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@gibizer @fmount @stuggi Hey folks, happy New Year. Welcome to 2026. Trying to solve a problem with IPV6 addresses raised by: I had initially proposed doing it this way: I know that @deshipu wasn't a huge fan of that implementation from the beginning. So, this is an attempt to find a compromise and still fix the problem of allowing Liveness/Readiness probes to healthcheck the individual pods. What do y'all think of this alternative? |
This change uses the `lib-common` env `DownwardAPI` [1] to write the pods IP to the env vars of the pod. We then retrieve this in `local_settings.py` to populate `ALLOWED_HOSTS`. [1] https://github.com/openstack-k8s-operators/lib-common/blob/main/modules/common/env/env.go#L100-L114 Fixes openstack-k8s-operators#487 Jira: https://issues.redhat.com/browse/OSPRH-19216 Signed-off-by: Brendan Shephard <[email protected]>
e822a85 to
3b10d73
Compare
|
Maybe we can avoid putting anything in That might be an even nicer approach actually - assuming that would actually work. Like, a request to the pod IP, but setting the |
|
Hi and Happy New Year! If it works as intended, I'd prefer this implementation. its simple and easy. |
This change uses the
lib-commonenvDownwardAPI[1] to write the pods IP to the env vars of the pod. We then retrieve this inlocal_settings.pyto populateALLOWED_HOSTS.[1] https://github.com/openstack-k8s-operators/lib-common/blob/main/modules/common/env/env.go#L100-L114
Fixes #487
Jira: https://issues.redhat.com/browse/OSPRH-19216