Skip to content

[memcached] add funcs to return quoted serverList and update test helpers #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2024
Merged

[memcached] add funcs to return quoted serverList and update test helpers #198

merged 1 commit into from
Mar 12, 2024

Conversation

@stuggi
Copy link
Contributor

@stuggi stuggi commented Mar 12, 2024

For tls, in #192 changed the server lists to contain the svc fqdn, but missed to update the test helpers.

@stuggi
[memcached] add funcs to return quoted serverList and update test hel…
041b81b 
…pers

For tls, in openstack-k8s-operators#192
changed the server lists to contain the svc fqdn, but missed to
update the test helpers.
@stuggi stuggi requested a review from abays March 12, 2024 11:12
@openshift-ci openshift-ci bot requested review from olliewalsh and viroel March 12, 2024 11:12
abays
abays approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 12, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Mar 12, 2024

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/60a22c88fb604607823fed44c04f7cbe

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 29m 32s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 06m 57s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 4s

@abays
Copy link
Contributor

abays commented Mar 12, 2024

recheck

@openshift-merge-bot openshift-merge-bot bot merged commit 5d715a2 into openstack-k8s-operators:main Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abays abays abays approved these changes

@olliewalsh olliewalsh Awaiting requested review from olliewalsh

@viroel viroel Awaiting requested review from viroel

Assignees

@abays abays

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stuggi @abays