Fix issues with metallb on OKD

Makefile

@@ -2463,16 +2463,10 @@ metallb: ## installs metallb operator in the metallb-system namespace
 	oc apply -f ${OUT}/${NAMESPACE}/namespace.yaml
 	timeout $(TIMEOUT) bash -c "while ! (oc get project.v1.project.openshift.io ${NAMESPACE}); do sleep 1; done"
 ifeq ($(OKD), true)
-	bash scripts/gen-operatorshub-catalog.sh
-	oc apply -f ${OPERATOR_DIR}/operatorshub-catalog/
-	timeout ${TIMEOUT} bash -c "while ! (oc get packagemanifests metallb-operator --no-headers=true | grep metallb-operator); do sleep 10; done"
 	bash scripts/gen-olm-metallb-okd.sh
-	oc apply -f ${OPERATOR_DIR}
-	timeout ${TIMEOUT} bash -c "while ! (oc get deployment metallb-operator-controller-manager --no-headers=true -n ${NAMESPACE}| grep metallb-operator-controller-manager); do sleep 10; done"
-	oc apply -f ${OPERATOR_DIR}/patches
+	oc apply -k ${OPERATOR_DIR}/config/openshift
+	oc apply -f ${OPERATOR_DIR}/config/metallb_rbac/metallb-openshift.yaml
 	oc wait -n ${NAMESPACE} --for=condition=Available deployment/metallb-operator-controller-manager --timeout=${TIMEOUT}
-	# we ensure the outdated replica is terminated (i.e only one replica available)
-	timeout ${TIMEOUT} bash -c "while ! (oc get pod --no-headers=true -l control-plane=controller-manager -n ${NAMESPACE}| grep metallb-operator-controller | wc -l | grep -q -e 1); do sleep 10; done"
 else
 	bash scripts/gen-olm-metallb.sh
 	oc apply -f ${OPERATOR_DIR}

scripts/gen-olm-metallb-okd.sh

@@ -38,48 +38,9 @@ fi
 echo OPERATOR_DIR ${OPERATOR_DIR}
 echo DEPLOY_DIR ${DEPLOY_DIR}
 
-cat > ${OPERATOR_DIR}/operatorgroup.yaml <<EOF_CAT
-apiVersion: operators.coreos.com/v1
-kind: OperatorGroup
-metadata:
-  name: metallb-operator
-  namespace: metallb-system
-EOF_CAT
-
-cat > ${OPERATOR_DIR}/subscription.yaml <<EOF_CAT
-apiVersion: operators.coreos.com/v1alpha1
-kind: Subscription
-metadata:
-  name: metallb-operator-sub
-  namespace: metallb-system
-spec:
-  channel: beta
-  name: metallb-operator
-  source: operatorhubio-catalog
-  sourceNamespace: openshift-marketplace
-EOF_CAT
-
-cat > ${OPERATOR_DIR}/patches/patch-deployment-controller-manager.yaml <<EOF_CAT
-apiVersion: apps/v1
-kind: Deployment
-metadata:
-  name: metallb-operator-controller-manager
-  namespace: metallb-system
-spec:
-  template:
-    spec:
-      containers:
-      - name: manager
-        env:
-        - name: DEPLOY_SERVICEMONITORS
-          value: "true"
-        - name: METALLB_BGP_TYPE
-          value: "frr"
-        - name: FRR_IMAGE
-          value: quay.io/frrouting/frr:8.4.2
-EOF_CAT
+curl -L https://github.com/metallb/metallb-operator/archive/refs/tags/v0.14.2.tar.gz | tar -xz --strip-components=1 -C ${OPERATOR_DIR}
 
-cat > ${OPERATOR_DIR}/patches/patch-deployment-webhook-server.yaml <<EOF_CAT
+cat > ${OPERATOR_DIR}/config/openshift/patch-deployment-webhook-server.yaml <<EOF_CAT
 apiVersion: apps/v1
 kind: Deployment
 metadata:
@@ -90,27 +51,22 @@ spec:
     spec:
       containers:
       - name: webhook-server
+        image: quay.io/metallb/controller:v0.14.5
         env:
         - name: DEPLOY_SERVICEMONITORS
           value: "true"
         - name: METALLB_BGP_TYPE
           value: "frr"
 EOF_CAT
 
-cat > ${OPERATOR_DIR}/patches/privileged-role-binding.yaml <<EOF_CAT
-apiVersion: rbac.authorization.k8s.io/v1
-kind: ClusterRoleBinding
-metadata:
-  name: system:openshift:scc:privileged
-roleRef:
-  apiGroup: rbac.authorization.k8s.io
-  kind: ClusterRole
-  name: system:openshift:scc:privileged
-subjects:
-- kind: ServiceAccount
-  name: controller
-  namespace: metallb-system
-EOF_CAT
+patch ${OPERATOR_DIR}/config/openshift/kustomization.yaml <<EOF_PATCH
+@@ -8,4 +8,5 @@
+ patches:
+ - path: patch-namespace.yaml
+ - path: patch-deployment-controller-manager.yaml
++- path: patch-deployment-webhook-server.yaml
+ namespace: metallb-system
+EOF_PATCH
 
 cat > ${DEPLOY_DIR}/deploy_operator.yaml <<EOF_CAT
 apiVersion: metallb.io/v1beta1