Skip to content

Conversation

@mauricioharley
Copy link

This PR introduces support for deploying Barbican with Hardware Security Module (HSM) capabilities using custom container images.

Changes

Makefile Updates

  • New Variables: Added BARBICAN_API_IMAGE, BARBICAN_WORKER_IMAGE, and BARBICAN_HSM_ENABLED to control HSM deployments
  • Conditional Image Logic: When BARBICAN_HSM_ENABLED=true, custom images are used if provided via the new variables
  • Deploy Preparation: Updated barbican_deploy_prep target to properly handle custom image deployment with correct image paths
  • Environment Export: Added HSM-related variables to openstack_init target exports

Standalone Script Updates

  • Backend Selection: Modified devsetup/standalone/openstack.sh to conditionally select between:
    • barbican-backend-pkcs11.yaml when HSM is enabled
    • barbican-backend-simple-crypto.yaml for standard deployments

Usage

To deploy Barbican with HSM support:

make openstack BARBICAN_HSM_ENABLED=true \
    BARBICAN_API_IMAGE=<your-hsm-api-image> \
    BARBICAN_WORKER_IMAGE=<your-hsm-worker-image>

- Add new Makefile variables for HSM-enabled Barbican deployments:
  BARBICAN_API_IMAGE, BARBICAN_WORKER_IMAGE, BARBICAN_HSM_ENABLED
- Add conditional logic to use custom images when HSM is enabled
- Update barbican_deploy_prep target to handle custom image deployment
- Add HSM backend selection in standalone openstack.sh script
- Support PKCS#11 backend when BARBICAN_HSM_ENABLED=true

Signed-off-by: Mauricio Harley <[email protected]>
@openshift-ci openshift-ci bot requested review from raukadah and slagle August 28, 2025 10:36
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mauricioharley
Once this PR has been reviewed and has the lgtm label, please assign fmount for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mauricioharley mauricioharley requested a review from abays August 28, 2025 10:36
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1b53de6c9a2849c79dc4aa80b085abf9

openstack-k8s-operators-content-provider TIMED_OUT in 30m 50s
⚠️ install-yamls-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-no-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant