Skip to content

Change IP_ADRESS_SUFFIX to IP_ADDRESS_SUFFIX#1133

Open
danpawlik wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
danpawlik:change-address-var
Open

Change IP_ADRESS_SUFFIX to IP_ADDRESS_SUFFIX#1133
danpawlik wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
danpawlik:change-address-var

Conversation

@danpawlik
Copy link
Contributor

The variable miss a character, which raise a warning on spell checking. It was done using sed command:

find devsetup -type f -exec sed -i 's/IP_ADRESS_SUFFIX/IP_ADDRESS_SUFFIX/g' {} +;

The variable miss a character, which raise a warning on spell checking.
It was done using sed command:

    find devsetup -type f -exec sed -i 's/IP_ADRESS_SUFFIX/IP_ADDRESS_SUFFIX/g' {} +;

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danpawlik
Once this PR has been reviewed and has the lgtm label, please assign fultonj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from raukadah January 29, 2026 10:17
@danpawlik danpawlik requested a review from dprince January 29, 2026 10:18
danpawlik added a commit to danpawlik/rhoso-rhelai that referenced this pull request Jan 29, 2026
The variable name contains an error, that raises a warning during spell
check.

Depends-On: openstack-k8s-operators/install_yamls#1133
Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
@danpawlik
Copy link
Contributor Author

just fyi:
when this is merged, please merge also:

Copy link
Contributor

@bogdando bogdando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather issued a warning msg, if using the old var, and added the new var to work the same way. Or we might become surprised with a blast radius of this change

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/31fff681312b42a28598f508771a18f1

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 18m 54s
✔️ install-yamls-crc-podified-edpm-baremetal SUCCESS in 1h 21m 16s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 00m 13s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 00m 44s
adoption-standalone-to-crc-no-ceph-provider NODE_FAILURE Node request 099-0008149042 failed in 0s

@danpawlik
Copy link
Contributor Author

@bogdando it is used in 2 places: rdo-jobs, rhoso-rhelai. Don't see anything downstream.
I don't see any reason to add warning, especially that there is some default value.

@bogdando bogdando self-requested a review February 2, 2026 09:15
Copy link
Contributor

@bogdando bogdando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants