Skip to content

Update LastAppliedTopology to TopologyRef interface#517

Merged
openshift-merge-bot[bot] merged 2 commits intoopenstack-k8s-operators:mainfrom
fmount:topologyref
Feb 24, 2025
Merged

Update LastAppliedTopology to TopologyRef interface#517
openshift-merge-bot[bot] merged 2 commits intoopenstack-k8s-operators:mainfrom
fmount:topologyref

Conversation

@fmount
Copy link
Copy Markdown
Contributor

@fmount fmount commented Feb 20, 2025

This patch updates the SpecCore webhook interface to accept the Namespace as parameter. This change ensures that we properly validate the referenced topology from openstack-operator, rejecting requests with a different namespace. It also aligns "LastAppliedTopology" to "TopologyRef" interface. While TopologyRef is able to reference Name and namespace, we currently only save TopologyRef.Name to .Status.LastAppliedTopology. This patch aligns both interfaces to use the same type in the same form. In addition, some logic is moved to infra-operator because is common to all operators, and this patch also adopts this new form.

Depends-On: openstack-k8s-operators/openstack-operator#1306

This patch updates the SpecCore webhook interface to accept the
Namespace as parameter. This change ensures that we properly
validate the referenced topology from openstack-operator, rejecting
requests with a different namespace.

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e11fb3d2b2f64124be92b5fefd0af653

✔️ noop SUCCESS in 0s
openstack-k8s-operators-content-provider FAILURE in 14m 52s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul
Copy link
Copy Markdown

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#1306 is needed.

While TopologyRef is able to reference Name and namespace, we currently
only save TopologyRef.Name to .Status.LastAppliedTopology. This patch
aligns both interfaces to use the same type in the same form. In
addition, some logic is moved to infra-operator because is common to all
operators, and this patch also adopts this new form.

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
Copy link
Copy Markdown
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 49ab890 into openstack-k8s-operators:main Feb 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants