Skip to content

Switch Topology defaultLabelSelector to lib-common GetLabelSelector#518

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
fmount:topologyref
Feb 27, 2025
Merged

Switch Topology defaultLabelSelector to lib-common GetLabelSelector#518
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
fmount:topologyref

Conversation

@fmount
Copy link
Copy Markdown
Contributor

@fmount fmount commented Feb 27, 2025

No description provided.

@fmount fmount requested review from olliewalsh and stuggi February 27, 2025 09:06
@fmount
Switch Topology defaultLabelSelector to lib-common GetLabelSelector
6da5dc7 
Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Feb 27, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/85f90a83ea55448da45ca0ed5048cbf7

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 04m 18s
❌ podified-multinode-ironic-deployment FAILURE in 44m 36s

@stuggi
Copy link
Copy Markdown
Contributor

stuggi commented Feb 27, 2025

recheck

@fmount
Copy link
Copy Markdown
Contributor Author

fmount commented Feb 27, 2025

@stuggi This is good to go

stuggi
stuggi approved these changes Feb 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 27, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6ee06c4 into openstack-k8s-operators:main Feb 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuggi stuggi stuggi approved these changes

@olliewalsh olliewalsh Awaiting requested review from olliewalsh

@hjensas hjensas Awaiting requested review from hjensas

@juliakreger juliakreger Awaiting requested review from juliakreger

Assignees

@stuggi stuggi

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fmount @stuggi