Skip to content

[functional] verify LastAppliedTopology != nil before checking name#525

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
stuggi:topo_func
Mar 7, 2025
Merged

[functional] verify LastAppliedTopology != nil before checking name#525
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
stuggi:topo_func

Conversation

@stuggi
Copy link
Copy Markdown
Contributor

@stuggi stuggi commented Mar 7, 2025 •
edited by openshift-ci bot
Loading

Related: OSPRH-14494

@stuggi
[functional] verify LastAppliedTopology != nil before checking name
2e993ac 
Related: OSPRH-14494

Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@stuggi stuggi requested a review from fmount March 7, 2025 11:24
@openshift-ci openshift-ci bot requested review from frenzyfriday and steveb March 7, 2025 11:24
@openshift-ci openshift-ci bot added the approved label Mar 7, 2025
fmount
fmount approved these changes Mar 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 7, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi
Copy link
Copy Markdown
Contributor Author

stuggi commented Mar 7, 2025

/cherry-pick 18.0-fr2

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Mar 7, 2025

@stuggi: once the present PR merges, I will cherry-pick it on top of 18.0-fr2 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick 18.0-fr2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit fdb84c8 into openstack-k8s-operators:main Mar 7, 2025
6 checks passed
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Mar 7, 2025

@stuggi: new pull request created: #526

Details

In response to this:

/cherry-pick 18.0-fr2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmount fmount fmount approved these changes

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday

@steveb steveb Awaiting requested review from steveb

Assignees

@fmount fmount

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stuggi @openshift-cherrypick-robot @fmount