Fix configuration of ironic neutron agent Jira: <OSPRH-10696>#545
Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom Apr 28, 2025
Conversation
mumesan
commented
Apr 23, 2025
hjensas
requested changes
Apr 23, 2025
templates/ironicneutronagent/config/ironic-neutron-agent-config.json
Outdated
Show resolved
Hide resolved
mumesan
force-pushed
the
custom_service_config_osprh_10696
branch
from
6fb9ff8 to
116e4af
Compare
hjensas
reviewed
Apr 23, 2025
templates/ironicneutronagent/config/ironic-neutron-agent-config.json
Outdated
Show resolved
Hide resolved
mumesan
force-pushed
the
custom_service_config_osprh_10696
branch
from
116e4af to
51e5fcf
Compare
Contributor
Author
|
/test ironic-operator-build-deploy-kuttl |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
hjensas
reviewed
Apr 23, 2025
mumesan
force-pushed
the
custom_service_config_osprh_10696
branch
from
51e5fcf to
37332a7
Compare
This comment was marked as resolved.
This comment was marked as resolved.
hjensas
dismissed
their stale review
With the latest revision, changes to the CR rolls out as they should.
hjensas
requested changes
Apr 26, 2025
Contributor
hjensas
left a comment
hjensas
left a comment
There was a problem hiding this comment.
Almost there, a nit about leaving re-using existing resource names + bonus if we can cleanup the scripts secret in a follow up.
mumesan
force-pushed
the
custom_service_config_osprh_10696
branch
from
37332a7 to
8e143d9
Compare
hjensas
approved these changes
Apr 28, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hjensas, mumesan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 0f997ed
into
openstack-k8s-operators:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: OSPRH-10696