Skip to content

Fix configuration of ironic inspector Jira: <OSPRH-10696>#555

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
mumesan:ironic_inspector_custom_service_config_osprh_10696
May 22, 2025
Merged

Fix configuration of ironic inspector Jira: <OSPRH-10696>#555
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
mumesan:ironic_inspector_custom_service_config_osprh_10696

Conversation

@mumesan
Copy link
Copy Markdown
Contributor

@mumesan mumesan commented May 19, 2025

  • Refactored to use --config-dir instead of crudini and removed init.sh

Jira: OSPRH-10696

@openshift-ci openshift-ci bot requested review from dprince and juliakreger May 19, 2025 12:19
@mumesan
Copy link
Copy Markdown
Contributor Author

mumesan commented May 19, 2025

/test ironic-operator-build-deploy-kuttl

@mumesan mumesan force-pushed the ironic_inspector_custom_service_config_osprh_10696 branch from bd3d928 to 213b19c Compare May 19, 2025 17:00
Copy link
Copy Markdown
Contributor

@hjensas hjensas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some comments, not sure why but I don't see the conf.d directory when doing rsh to the container. I will continue looking ...

@mumesan mumesan force-pushed the ironic_inspector_custom_service_config_osprh_10696 branch from 213b19c to 4d4814d Compare May 22, 2025 08:11
@mumesan mumesan force-pushed the ironic_inspector_custom_service_config_osprh_10696 branch from 4d4814d to aeffd61 Compare May 22, 2025 10:43
Copy link
Copy Markdown
Contributor

@hjensas hjensas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this, it provisions the service and I was able to run introspection of a node succesfully.

sh-5.1$ openstack baremetal introspection list
+--------------------------------------+---------------------+---------------------+-------+
| UUID                                 | Started at          | Finished at         | Error |
+--------------------------------------+---------------------+---------------------+-------+
| 1b92f15c-411c-42a1-a806-d7d6d05a507a | 2025-05-22T17:45:03 | 2025-05-22T17:46:14 | None  |
+--------------------------------------+---------------------+---------------------+-------+

@openshift-ci openshift-ci bot added the lgtm label May 22, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented May 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hjensas, mumesan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5fbe9bd into openstack-k8s-operators:main May 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants