Skip to content

Fix race condition - envsubst $file | tee $file #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jun 2, 2025
Merged

Fix race condition - envsubst $file | tee $file #558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions templates/ironicinspector/bin/inspector-pxe-init.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,19 @@ sed -e "/BLOCK_PODINDEX_${PODINDEX}_BEGIN/,/BLOCK_PODINDEX_${PODINDEX}_END/p" \
sed -e "/BLOCK_PODINDEX_${PODINDEX}_BEGIN/d" \
-e "/BLOCK_PODINDEX_${PODINDEX}_END/d" \
-i ${DNSMASQ_CFG}
envsubst < ${DNSMASQ_CFG} | tee ${DNSMASQ_CFG}

# OSPCIX-870: Copy the config to tempdir to avoid race condition where pipe to
# tee may wipe the file.
export TMP_DNSMASQ_CFG=/var/tmp/dnsmasq.conf
cp ${DNSMASQ_CFG} ${TMP_DNSMASQ_CFG}
envsubst < ${TMP_DNSMASQ_CFG} | tee ${DNSMASQ_CFG}

export INSPECTOR_IPXE=/var/lib/ironic/inspector.ipxe
envsubst < ${INSPECTOR_IPXE} | tee ${INSPECTOR_IPXE}
# OSPCIX-870: Copy the config to tempdir to avoid race condition where pipe to
# tee may wipe the file.
export TMP_INSPECTOR_IPXE=/var/tmp/inspector.ipxe
cp ${INSPECTOR_IPXE} ${TMP_INSPECTOR_IPXE}
envsubst < ${TMP_INSPECTOR_IPXE} | tee ${INSPECTOR_IPXE}

# run common pxe-init script
/usr/local/bin/container-scripts/pxe-init.sh