Skip to content

Remove configMapFn and refactor findObjectsForSrc <JIRA: OSPRH-10696>#572

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
mumesan:remove_configmapfn_OSPRH-10696
Jul 4, 2025
Merged

Remove configMapFn and refactor findObjectsForSrc <JIRA: OSPRH-10696>#572
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
mumesan:remove_configmapfn_OSPRH-10696

Conversation

@mumesan
Copy link
Copy Markdown
Contributor

@mumesan mumesan commented Jul 4, 2025

Continuation of commit: #570

In commit: 95b3db1 there was a switch
from using ConfigMap to using secret.

-       return configmap.EnsureConfigMaps(ctx, h, instance, cms, envVars)
+       return secret.EnsureSecrets(ctx, h, instance, cms, envVars)

In this PR:

  • configMapFn is residual code and can be removed because the return is secret and not configmap.
  • make ironic-api and ironic-conductor pods reboot when changes are made to the base level customServiceConfig configuration.

Jira: OSPRH-10696

@openshift-ci openshift-ci bot requested review from frenzyfriday and stuggi July 4, 2025 08:23
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hjensas, mumesan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 4, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 90da9d8 into openstack-k8s-operators:main Jul 4, 2025
7 checks passed
hjensas pushed a commit to hjensas/ironic-operator that referenced this pull request Jul 22, 2025
…nfigmapfn_OSPRH-10696

Remove configMapFn and refactor findObjectsForSrc <JIRA: OSPRH-10696>
mumesan pushed a commit to mumesan/ironic-operator that referenced this pull request Jul 22, 2025
…nfigmapfn_OSPRH-10696

Remove configMapFn and refactor findObjectsForSrc <JIRA: OSPRH-10696>
mumesan pushed a commit to mumesan/ironic-operator that referenced this pull request Jul 22, 2025
…nfigmapfn_OSPRH-10696

Remove configMapFn and refactor findObjectsForSrc <JIRA: OSPRH-10696>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants