Skip to content

Use setup-envtest@release-0.22 for ironic#629

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
dprince:setup_env_022
Oct 15, 2025
Merged

Use setup-envtest@release-0.22 for ironic#629
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
dprince:setup_env_022

Conversation

@dprince
Copy link
Copy Markdown
Contributor

@dprince dprince commented Oct 14, 2025

Summary

  • Add SETUP_ENVTEST_VERSION variable to Makefile
  • Update setup-envtest installation to use release-0.22

kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.
@openshift-ci openshift-ci bot requested review from steveb and viroel October 14, 2025 14:49
@abays
Copy link
Copy Markdown
Contributor

abays commented Oct 15, 2025

/cherry-pick 18.0-fr4

@openshift-cherrypick-robot
Copy link
Copy Markdown

@abays: once the present PR merges, I will cherry-pick it on top of 18.0-fr4 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick 18.0-fr4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Oct 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, dprince

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit aaacebc into openstack-k8s-operators:main Oct 15, 2025
7 checks passed
@openshift-cherrypick-robot
Copy link
Copy Markdown

@abays: new pull request created: #630

Details

In response to this:

/cherry-pick 18.0-fr4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants