Skip to content

Remove TODO in validateDelete function <JIRA: OSPRH-18888>#637

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
mumesan:OSPRH-18888
Oct 27, 2025
Merged

Remove TODO in validateDelete function <JIRA: OSPRH-18888>#637
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
mumesan:OSPRH-18888

Conversation

@mumesan
Copy link
Copy Markdown
Contributor

@mumesan mumesan commented Oct 24, 2025

Describe your changes

The validateDelete function will not be implemented and it cannot be removed as a no-op because webhook.Validator has this as an interface. Hence just the TODO comment is removed and replaced with a note.

Jira Ticket Link

Jira: OSPRH-18888

Checklist before requesting a review

  • I have performed a self-review of my code and confirmed it passes tests
  • Performed pre-commit run --all
  • Tested operator image in a test/dev environment. It can be CRC via install_yamls or a hotstack instance (optional)
  • Verified that no failures present in logs(optional):
    • ironic-operator-build-deploy-kuttl
    • podified-multinode-ironic-deployment

@openshift-ci openshift-ci bot requested review from abays and hjensas October 24, 2025 09:15
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Oct 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hjensas, mumesan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1efd0f6 into openstack-k8s-operators:main Oct 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants