Skip to content

Application Credential support#656

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
Deydra71:appcred-support
Jan 30, 2026
Merged

Application Credential support#656
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
Deydra71:appcred-support

Conversation

@Deydra71
Copy link
Copy Markdown

@Deydra71 Deydra71 commented Dec 10, 2025

Jira: OSPRH-20521

Adds the end-to-end support for consuming Keystone ApplicationCredentials (AC) in the ironic-operator, enabling IronicAPI,Conductor, Inspector NeutronAGent pods to use AC-based authentication when available.

API changes:

Adds an optional authentication field to the Ironic CRs:

spec.auth.applicationCredentialSecret — name of the Secret that contains the Keystone Application Credential ID and Secret (AC_ID and AC_SECRET).

Reconcile behavior:

Reads spec.auth.applicationCredentialSecret
Attempts to load AC_ID / AC_SECRET from the referenced Secret (via the Keystone helper).
If the secret is missing or incomplete, it falls back to password authentication (the AppCred auth is optional, not an error).

  • Once the AC Secret is ready with valid AC_ID and AC_SECRET fields, templates AC credentials into the respective service configuration (ironic.conf, 01-api.conf, 01-inspector.conf, or 01-ironic_neutron_agent.conf)
  • Computes hash of Secret contents and stores in configMapVars to trigger rolling updates when credentials rotate
  • Separate AppCreds are used for 'ironic' user (IronicAPI, IronicConductor, IronicNeutronAgent, parent Ironic) and 'ironic-inspector' user (IronicInspector)

Depends-On: openstack-k8s-operators/keystone-operator#567

@softwarefactory-project-zuul
Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ironic-operator for 656,6b592f6a3f430ea960129d5b540ec9dc59773612

@apevec
Copy link
Copy Markdown

apevec commented Jan 21, 2026

@Deydra71 depends-on has been merged, and now PR needs rebase afaict
@juliakreger @hjensas what else do we need in order to review this PR?

@Deydra71
Copy link
Copy Markdown
Author

@apevec the dependency is merged, but not bumped yet. The conflicts appeared after the SKMO changes #670

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/626a8b4aaf0f49eab14a0b93913f6540

openstack-k8s-operators-content-provider FAILURE in 17m 18s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@juliakreger
Copy link
Copy Markdown
Contributor

@Deydra71 So when you update the vendoring/replacement, are you going to rebase this change?

@Deydra71
Copy link
Copy Markdown
Author

@juliakreger yes, but even the keystone-operator patch is merged now, the version bump with the app cred change didn't happen yet

@juliakreger
Copy link
Copy Markdown
Contributor

@Deydra71 When you have a chance, If you can let @apevec know so we can set expectations when we'll be able to appropriately re-review and hopefully merge this change, that would be helpful. Thanks!

@xek xek force-pushed the appcred-support branch 2 times, most recently from ad156df to d2e5d04 Compare January 27, 2026 12:39
Copy link
Copy Markdown
Contributor

@hjensas hjensas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, for addressing the review comments. A couple comments on the update.

@softwarefactory-project-zuul
Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ironic-operator for 656,bbb32d526b13fd04370ba89827e23a351624954d

@xek xek force-pushed the appcred-support branch 3 times, most recently from e2f2eb5 to 028dfbf Compare January 28, 2026 11:14
@hjensas
Copy link
Copy Markdown
Contributor

hjensas commented Jan 29, 2026

FYI, I did a rebase and go mod tidy to fix the conflicts in api/go.mod and api/go.sum only.

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f7ba2fd4bc724e24831bb39c34a65f43

openstack-k8s-operators-content-provider FAILURE in 17m 39s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@xek xek force-pushed the appcred-support branch 3 times, most recently from cc117e5 to a52b93f Compare January 29, 2026 15:30
@softwarefactory-project-zuul
Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ironic-operator for 656,a52b93fbfbffa30f40f43239b05105cb790617fb

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d63e811e6a7b4c5592f22a7a9ad543f3

openstack-k8s-operators-content-provider FAILURE in 14m 38s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@xek xek force-pushed the appcred-support branch 2 times, most recently from ad9165c to bd9605e Compare January 29, 2026 16:57
@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/32601923be06457790c9e307db51d4c0

openstack-k8s-operators-content-provider FAILURE in 12m 32s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

Co-authored-by: Cursor <cursoragent@cursor.com>
@xek xek force-pushed the appcred-support branch from bd9605e to 775e27e Compare January 30, 2026 08:04
@hjensas
Copy link
Copy Markdown
Contributor

hjensas commented Jan 30, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 30, 2026
@juliakreger
Copy link
Copy Markdown
Contributor

/lgtm

@mumesan
Copy link
Copy Markdown
Contributor

mumesan commented Jan 30, 2026

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Deydra71, hjensas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 89a4663 into openstack-k8s-operators:main Jan 30, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants