Application Credential support#656
Application Credential support#656openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
6b592f6 to
5c19d77
Compare
5c19d77 to
e3b9c34
Compare
e3b9c34 to
10e4d47
Compare
|
@Deydra71 depends-on has been merged, and now PR needs rebase afaict |
10e4d47 to
e02c23e
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/626a8b4aaf0f49eab14a0b93913f6540 ❌ openstack-k8s-operators-content-provider FAILURE in 17m 18s |
|
@Deydra71 So when you update the vendoring/replacement, are you going to rebase this change? |
|
@juliakreger yes, but even the keystone-operator patch is merged now, the version bump with the app cred change didn't happen yet |
ad156df to
d2e5d04
Compare
hjensas
left a comment
There was a problem hiding this comment.
Thanks, for addressing the review comments. A couple comments on the update.
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
e2f2eb5 to
028dfbf
Compare
|
FYI, I did a rebase and |
4308cec to
9dfa1c3
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f7ba2fd4bc724e24831bb39c34a65f43 ❌ openstack-k8s-operators-content-provider FAILURE in 17m 39s |
cc117e5 to
a52b93f
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d63e811e6a7b4c5592f22a7a9ad543f3 ❌ openstack-k8s-operators-content-provider FAILURE in 14m 38s |
ad9165c to
bd9605e
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/32601923be06457790c9e307db51d4c0 ❌ openstack-k8s-operators-content-provider FAILURE in 12m 32s |
Co-authored-by: Cursor <cursoragent@cursor.com>
|
/lgtm |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Deydra71, hjensas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
89a4663
into
openstack-k8s-operators:main
Jira: OSPRH-20521
Adds the end-to-end support for consuming Keystone ApplicationCredentials (AC) in the ironic-operator, enabling IronicAPI,Conductor, Inspector NeutronAGent pods to use AC-based authentication when available.
API changes:
Adds an optional authentication field to the Ironic CRs:
spec.auth.applicationCredentialSecret— name of the Secret that contains the Keystone Application Credential ID and Secret (AC_ID and AC_SECRET).Reconcile behavior:
Reads
spec.auth.applicationCredentialSecretAttempts to load AC_ID / AC_SECRET from the referenced Secret (via the Keystone helper).
If the secret is missing or incomplete, it falls back to password authentication (the AppCred auth is optional, not an error).
Depends-On: openstack-k8s-operators/keystone-operator#567