Add missing tags to []conditions which got reported by crd checker #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tags which to resolve the condition failures reported by the crd checker recently added as a pre-commit validation. In a follow up, we should integrate the new ObservedGeneration for a condition [1]. The observedGeneration represents the .metadata.generation that the condition was set based upon. [1] https://github.com/kubernetes/apimachinery/blob/release-1.29/pkg/apis/meta/v1/types.go#L1518 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
force-pushed
the
cond_list_tags
branch
from
8d4a591 to
38245c2
Compare
Contributor
|
I think some of these validations will go into the CRD yamls thus increasing the size. want to be sure we are actually getting value out of these vs. just making a tool like crd-schema-checker happy |
bogdando
reviewed
Dec 3, 2024
Contributor
bogdando
left a comment
bogdando
left a comment
There was a problem hiding this comment.
this minimal scoped change looks better to me than the 584th pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tags which to resolve the condition failures reported by the crd checker recently added as a pre-commit validation.
In a follow up, we should integrate the new ObservedGeneration for a condition [1]. The observedGeneration represents the .metadata.generation that the condition was set based upon.
[1] https://github.com/kubernetes/apimachinery/blob/release-1.29/pkg/apis/meta/v1/types.go#L1518