Add INI config utility to common/util module #641
+325
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmount
force-pushed
the
common_ini
branch
2 times, most recently
from
a062f07 to
aade7b9
Compare
stuggi
reviewed
Sep 29, 2025
This patch introduces a new INI manipulation utility with the ability to extend service configurations (customServiceConfig) by adding key-value pairs to specific sections. It includes comprehensive test coverage for various scenarios, including section detection, key validation, and edge cases. This utility does not replace existing keys if they are already specified via user input, and it optionally adds - based on the Unique parameter - keys of the same kind for a given section. This design preserves the original purpose of customServiceConfig as user input. Related: https://issues.redhat.com/browse/OSPRH-14309 Signed-off-by: Francesco Pantano <[email protected]>
Contributor
Author
|
@stuggi do you think this patch is good to go now? I think I enhanced the existing code to make sure we can decide to allow duplicated keys (and I added a couple of tests based on the Nova documentation). Let me know if you think we need more changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a new
INImanipulation utility with the ability to process/extend service configurations (customServiceConfig) by addingkey/valuepairs to specific sections. It includes comprehensive test coverage for various scenarios, including section detection, key validation, and edge cases. This utility does not replace existing keys if they are already specified via user input, but it can optionally add a duplicated key in the same section based on the IniOption flag. This design preserves the original purpose ofcustomServiceConfigas user input.Note: Since we already process
customServiceConfigin storage operators, lib-common seems to be a good fit for the use case.Related: https://issues.redhat.com/browse/OSPRH-14309