Skip to content

Conversation

@fmount
Copy link
Collaborator

@fmount fmount commented Mar 20, 2025

Kuttl tests are currently hard to follow, because we literally assert the entire resources associated to a Manila deployment. This patch aims to produce a big refactoring of the current kuttl testing, to achieve the following results:

  • Only match, within the deployed resources, what is meaningful to make the test fail or pass
  • Reorg kuttl tests in test suites, so we don't have to specify testDirs via cli because they have a dedicated kutt-test.yaml config file

Depends-On: openstack-k8s-operators/install_yamls#1027

Kuttl tests are currently hard to follow, because we literally assert
the entire resources associated to a Manila deployment. This patch aims
to produce a big refactoring of the current kuttl testing, to achieve
the following results:

1. Only match, within the deployed resources, what is meaningful to make
   the test fail or pass

2. Reorganize kuttl tests in test suites, so we don't have to specify
   the testDirs via cli but they live within the main kutt-test.yaml
   config file

Signed-off-by: Francesco Pantano <[email protected]>
@fmount fmount requested a review from gouthampacha March 20, 2025 09:23
@openshift-ci openshift-ci bot requested a review from dprince March 20, 2025 09:23
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fmount fmount requested review from vhariria and removed request for dprince March 20, 2025 09:23
fmount added a commit to fmount/install_yamls that referenced this pull request Mar 20, 2025
This patch aligns install_yamls to run manila kuttl tests using the new
form introduced by the code refactoring [1].

[1] openstack-k8s-operators/manila-operator#402

Signed-off-by: Francesco Pantano <[email protected]>
@softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/install_yamls#1027 is needed.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants