-
Notifications
You must be signed in to change notification settings - Fork 34
Add region support #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add region support #513
Conversation
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9586cdb582134040af8e53067d019834 ❌ openstack-k8s-operators-content-provider FAILURE in 10m 00s |
2a3818b to
1dd6e3e
Compare
|
recheck |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/653d228fb944489ab2c8564941ae080a ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 04m 19s |
According to the OpenStack inter-service region audit, Manila connects to Barbican via Castellan, which uses 'barbican_region_name' (NOT 'region_name') as the config option. Castellan defines this as a StrOpt in its Barbican key manager, and it's used for endpoint discovery. This change: - Updates the [barbican] section in manila config template to use barbican_region_name instead of region_name - Updates functional tests to verify barbican_region_name instead of region_name Reference: openstack-inter-service-region-audit.md line 35, 275-276
87352e5 to
30bc26b
Compare
fmount
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, vakwetu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Based on [1] (which is the same for the rest of the manila components) looks good to me. |
593d78f
into
openstack-k8s-operators:main
No description provided.