intermediary refactor of mariadbaccount_controller (PR 2 of 6) #343
+254
−268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzeek
changed the title
zzzeek
force-pushed
the
OSPRH-14916-pr2
branch
2 times, most recently
from
6eb6580 to
a65d379
Compare
zzzeek
force-pushed
the
OSPRH-14916-pr2
branch
2 times, most recently
from
0346897 to
b870e09
Compare
zzzeek
force-pushed
the
OSPRH-14916-pr2
branch
3 times, most recently
from
cbeb723 to
8f997c8
Compare
Contributor
|
This looks good to me, let's rebase it now that PR1/6 merged and we'll move it forward. |
this change reorganizes mariadbaccount_controller to move the majority of MariaDBDatabase fetch/wait logic as well as Galera fetch/wait logic to separate methods getMariaDBDatabaseForCreate, getMariaDBDatabaseForDelete, getGaleraForCreateOrDelete. This is to allow more flexibility for upcoming changes. All current functionality should remain identical within this commit.
zzzeek
force-pushed
the
OSPRH-14916-pr2
branch
from
8f997c8 to
41316e9
Compare
Contributor
|
/lgtm |
lmiccini
approved these changes
Nov 5, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmiccini, zzzeek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 29261cd
into
openstack-k8s-operators:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change reorganizes mariadbaccount_controller to move the majority
of MariaDBDatabase fetch/wait logic as well as Galera fetch/wait
logic to separate methods getMariaDBDatabaseForCreate,
getMariaDBDatabaseForDelete, getGaleraForCreateOrDelete. This is to
allow more flexibility for upcoming changes. All current functionality
should remain identical within this commit.