fix harness to not look for secret finalizers #378
Merged
+0
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in af80f46 we removed the client finalizer being added to the secret; it's added only to MariaDBAccount, where the MariaDBAccount maintains its own finalizer on the secret. However, we forgot to update the test harnesses in harnesses.go which check for client finalizers in both MariaDBAccount as well as the Secret; this change updates all those suites to not check inside the Secret since it no longer receives the finalizer.
zzzeek
requested review from
dciabrin and
stuggi
and removed request for
frenzyfriday and
olliewalsh
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmiccini, zzzeek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/lgtm I have tested locally the barbican dependincy bump PR which was failing since last week openstack-k8s-operators/barbican-operator#304, by forcing it to use @zzzeek's PR hash, and all 65/65 tests pass. Let's see how we can re-add tests for our finalizers in a subsequent PR, so we can unblock everyone here. |
This was referenced Nov 10, 2025
Open
Open
openshift-merge-bot
bot
merged commit e669472
into
openstack-k8s-operators:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in af80f46 we removed the client finalizer being added to the secret; it's added only to MariaDBAccount, where the MariaDBAccount maintains its own finalizer on the secret. However, we forgot to update the test harnesses in harnesses.go which check for client finalizers in both MariaDBAccount as well as the Secret; this change updates all those suites to not check inside the Secret since it no longer receives the finalizer.