Skip to content

Conversation

@ratailor
Copy link
Contributor

  • Replace GetKeystoneAPI with GetKeystoneAPIByName in nova_controller.go
  • use instance.Spec.KeystoneInstance directly instead of empty label map
  • Remove TODO comment about changing the API usage.
  • Update keystone-operator/api dependency to support new functionality

This provides a more direct and efficient way to get the KeystoneAPI resource by name rather then searching by labels.

Commit message assisted by: claude-4-sonnet

@openshift-ci openshift-ci bot requested review from gibizer and viroel August 26, 2025 08:16
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ratailor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/642ccde50be5416f89097693654d72cb

✔️ openstack-meta-content-provider SUCCESS in 2h 51m 01s
✔️ nova-operator-kuttl SUCCESS in 43m 57s
✔️ nova-operator-tempest-multinode SUCCESS in 2h 12m 49s
nova-operator-tempest-multinode-ceph FAILURE in 2h 33m 40s

@ratailor ratailor force-pushed the use-GetKeystoneAPIByName branch from 4a0e940 to 333b27f Compare August 26, 2025 12:20
- Replace GetKeystoneAPI with GetKeystoneAPIByName in nova_controller.go
- use instance.Spec.KeystoneInstance directly instead of empty label map
- Remove TODO comment about changing the API usage.
- Update keystone-operator/api dependency to support new functionality

This provides a more direct and efficient way to get the KeystoneAPI
resource by name rather then searching by labels.

Commit message assisted by: claude-4-sonnet
@ratailor ratailor force-pushed the use-GetKeystoneAPIByName branch from 333b27f to 42427a7 Compare September 10, 2025 10:25
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 10, 2025

@ratailor: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional 42427a7 link true /test functional

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0a37fc843d32461ba235d449e3a82130

✔️ openstack-meta-content-provider SUCCESS in 2h 59m 48s
✔️ nova-operator-kuttl SUCCESS in 36m 56s
✔️ nova-operator-tempest-multinode SUCCESS in 2h 34m 22s
nova-operator-tempest-multinode-ceph FAILURE in 49m 15s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant