Skip to content

Conversation

@ratailor
Copy link
Contributor

@ratailor ratailor commented Jul 2, 2025

This change migrate nova-operator from single group operator to support multi-group operators, which is required to merge placement-operator code base from placement-operator into nova-operator.

Related: OSPRH-14957

@openshift-ci openshift-ci bot requested review from bogdando and lewisdenny July 2, 2025 14:06
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ratailor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ratailor ratailor requested review from gibizer and removed request for bogdando and lewisdenny July 2, 2025 14:06
@openshift-ci openshift-ci bot added the approved label Jul 2, 2025
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5925f9411a0b46c98ccba35ad9c94b59

openstack-meta-content-provider FAILURE in 55m 08s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

@bogdando
Copy link
Contributor

bogdando commented Jul 3, 2025

lgtm as this transition looks technically correct, albeit the upgrade path should be covered as well:

oscp operator creates the deployments for the controller managers for the operators. there is code needed to do the transition and delete the one for e.g. placement, and nova to reapear as multi-group

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a31134e8933347c9bc95f9e72170c2f1

openstack-meta-content-provider FAILURE in 45m 38s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4f082ed24864447680a12accb9919212

openstack-meta-content-provider FAILURE in 50m 46s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

@ratailor ratailor force-pushed the migrate-nova-to-multigroup branch from 4ad26aa to d80fef9 Compare August 20, 2025 11:00
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8182f70bb2bb4c3ab6fbb4a2bbe300eb

openstack-meta-content-provider FAILURE in 15m 31s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/nova-operator for 990,9957268476d179a0fe4e928ea623cdbb6cac892a

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0d6483d1aa7140ce80b7ab0d9faef213

openstack-meta-content-provider FAILURE in 10m 35s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

@ratailor ratailor force-pushed the migrate-nova-to-multigroup branch from a81e01b to 532331a Compare August 25, 2025 06:17
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/21ea5c6188264dcd8ea5687dfefce601

openstack-meta-content-provider FAILURE in 9m 24s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

This commit restructures the nova-operator codebase to support
multi-group operators by:

- Moving API definitions from api/ to apis/nova/v1beta1/
- Reorganizing controllers into controllers/nova/ directory
- Relocating test files to test/functional/nova/ and test/kuttl/nova/
- Updating all import paths and references throughout the codebase
- Modifying build and configuration files to work with new structure

This restructuring prepares the operator to support multiple API
groups, which is required to merge placement-operator codebase
into nova-operator

Commit message assisted by: claude-4-sonnet
Related: OSPRH-14957
@ratailor ratailor force-pushed the migrate-nova-to-multigroup branch from 532331a to b00359f Compare August 26, 2025 12:17
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7b8fbe91fbc2411595bb3d6ed437c144

openstack-meta-content-provider FAILURE in 9m 46s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

Copy link

@paramite paramite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, do we plan to have more that one KUTTL test suite for a service? I wonder why the kuttl tests moved to service subfolder while there could be default suite which deploys and verifies both nova and placement and then suite just for nova resources tests and suite just for placement resources tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants