Skip to content
This repository was archived by the owner on Nov 28, 2024. It is now read-only.

Conversation

@openstack-k8s-ci-robot
Copy link

@openstack-k8s-ci-robot openstack-k8s-ci-robot commented Sep 28, 2024

This PR contains the following updates:

Package Type Update Change
github.com/k8snetworkplumbingwg/network-attachment-definition-client require minor v1.4.0 -> v1.7.5

Release Notes

k8snetworkplumbingwg/network-attachment-definition-client (github.com/k8snetworkplumbingwg/network-attachment-definition-client)

v1.7.5

Compare Source

This release contains a fix related to the determination of the default interface, e.g. setting the default parameter to true in the network-status annotation based on the presence of a gateway in the CNI ADD success result ips.gateway and makes the determination of the default based on the first interface that has an associated value of gateway (using the interface index in the ips element in the CNI ADD success result).

This provides flexibility especially in CRI-O which uses the first interface and IP addresses for the pod.IP in Kubernetes, therefore. Containerd functionality is unchanged in that it uses the value for the IP addresses specifically

It's worth noting that CNI ADD success results which do not contain any interfaces will be discarded in this determination of the default, therefore it's recommended to set one with an associated gateway if aiming to have it be noted as the default.

v1.7.4

Compare Source

This release accounts for CNI plugins which do not use the sandbox field in results when calculating the network-status annotation, doing so for backwards compatibility for plugins which choose to not use this field (such as Calico)

v1.7.3

Compare Source

This release accounts for the sandox interfaces when reporting the interfaces in the network-status annotation; in case the CreateNetworkStatuses clients invoke it with a CNI result featuring non-sandbox interfaces as the first item in the list, this release accounts for that condition.

v1.7.2

Compare Source

When the CreateNetworkStatuses method was created to properly set the network-status annotation when a CNI result includes multiple interfaces in the return, it was found that it when setting the "default" parameter in the network-status, it was setting it to all the returned interfaces to true, which doesn't fit the NPWG net-attach-def specification.

This release fixes that issue by using the first interface in the CNI result set to "default": true for the cluster default network and not the following interfaces.

NOTE Do not use this version, use >= v1.7.3

v1.7.1

Compare Source

Adds the CreateNetworkStatuses method to properly set the network-status annotation when a CNI result includes multiple interfaces in the return.

For details of the before/after, see this gist: https://gist.github.com/dougbtv/1eb8ac2d61d494b56d65a6b236a86e61

For the related suggested update to the NPWG net-attach-def specification (for clarity only), see this proposal @​ https://docs.google.com/document/d/1DUTV-o6E6zlRTKZkxeDhAeyGrmq03qPgPbU580Rm7-g/edit

v1.7.0

Compare Source

Adds MTU to network-status

v1.6.0

Compare Source

Adds IPAMClaimReference to network-selection-elements

v1.5.0

Compare Source

What's Changed

New Contributors

Full Changelog: k8snetworkplumbingwg/network-attachment-definition-client@v1.4.0...v1.5.0


Configuration

📅 Schedule: Branch creation - "every weekend" in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@openstack-k8s-ci-robot
Copy link
Author

ℹ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 5 additional dependencies were updated
  • The go directive was updated for compatibility reasons

Details:

Package Change
go 1.20 -> 1.21.13
k8s.io/api v0.28.13 -> v0.29.0
k8s.io/apimachinery v0.28.13 -> v0.29.0
k8s.io/client-go v0.28.13 -> v0.29.0
golang.org/x/oauth2 v0.8.0 -> v0.10.0
k8s.io/kube-openapi v0.0.0-20230717233707-2695361300d9 -> v0.0.0-20231010175941-2dd684a91f00

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openstack-k8s-ci-robot
Once this PR has been reviewed and has the lgtm label, please assign frenzyfriday for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ee95f304651d49edbe017f808bbd5549

openstack-k8s-operators-content-provider FAILURE in 5m 25s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@openstack-k8s-ci-robot openstack-k8s-ci-robot force-pushed the renovate/network-attachment-definition-client branch from 925358e to 4f95e13 Compare September 30, 2024 09:14
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/effc33cc179e408da4c287928a7173e2

openstack-k8s-operators-content-provider FAILURE in 5m 47s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@openstack-k8s-ci-robot openstack-k8s-ci-robot changed the title Update module github.com/k8snetworkplumbingwg/network-attachment-definition-client to v1.7.3 Update module github.com/k8snetworkplumbingwg/network-attachment-definition-client to v1.7.4 Oct 5, 2024
@openstack-k8s-ci-robot openstack-k8s-ci-robot force-pushed the renovate/network-attachment-definition-client branch from 4f95e13 to 79bfb92 Compare October 5, 2024 04:25
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/644596e22f504ca2a65a55c3b2be6d1d

openstack-k8s-operators-content-provider FAILURE in 5m 23s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@openstack-k8s-ci-robot openstack-k8s-ci-robot changed the title Update module github.com/k8snetworkplumbingwg/network-attachment-definition-client to v1.7.4 Update module github.com/k8snetworkplumbingwg/network-attachment-definition-client to v1.7.5 Oct 19, 2024
@openstack-k8s-ci-robot openstack-k8s-ci-robot force-pushed the renovate/network-attachment-definition-client branch from 79bfb92 to 6c28d10 Compare October 19, 2024 05:06
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fcd96ee775f5464393f772d105b173a6

openstack-k8s-operators-content-provider FAILURE in 5m 31s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@openstack-k8s-ci-robot openstack-k8s-ci-robot force-pushed the renovate/network-attachment-definition-client branch from 6c28d10 to eb5e748 Compare November 4, 2024 09:37
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6f9b64e5ff2445d5a2079afc3d48642c

openstack-k8s-operators-content-provider FAILURE in 5m 36s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

@openstack-k8s-ci-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional eb5e748 link true /test functional
ci/prow/precommit-check eb5e748 link true /test precommit-check
ci/prow/ansibleee-operator-build-deploy-kuttl eb5e748 link true /test ansibleee-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants