Skip to content

Conversation

@olliewalsh
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from abays and dprince January 17, 2025 14:48
needs: check-secrets
name: Build ${{ inputs.operator_name }}-operator image using buildah
runs-on: ubuntu-latest
if: needs.check-secrets.outputs.missing-secrets != 'true'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally it would just be a case of if: ${ env.imagenamespace != ''} but very little data is available in the scope of the job conditionals. It's mostly just the status of other jobs, so need to workaround this by using a helper job to check the secrets.

The side-effect is that the overall result is the action is success, not skipped, so I've added an error message to make it clearer that the action has issues

@olliewalsh
Copy link
Contributor Author

image

@olliewalsh
Copy link
Contributor Author

/override ci/prow/images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

@olliewalsh: Overrode contexts on behalf of olliewalsh: ci/prow/images

Details

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 04b91a8 into openstack-k8s-operators:main Jan 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants