-
Notifications
You must be signed in to change notification settings - Fork 22
[github-action] Skip build jobs and warn if secrets are not set #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[github-action] Skip build jobs and warn if secrets are not set #117
Conversation
| needs: check-secrets | ||
| name: Build ${{ inputs.operator_name }}-operator image using buildah | ||
| runs-on: ubuntu-latest | ||
| if: needs.check-secrets.outputs.missing-secrets != 'true' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally it would just be a case of if: ${ env.imagenamespace != ''} but very little data is available in the scope of the job conditionals. It's mostly just the status of other jobs, so need to workaround this by using a helper job to check the secrets.
The side-effect is that the overall result is the action is success, not skipped, so I've added an error message to make it clearer that the action has issues
|
/override ci/prow/images |
|
@olliewalsh: Overrode contexts on behalf of olliewalsh: ci/prow/images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
stuggi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olliewalsh, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
04b91a8
into
openstack-k8s-operators:main

No description provided.