Update openstack-k8s-operators (main) #1395

openstack-k8s-ci-robot · 2025-04-05T04:43:38Z

This PR contains the following updates:

Package	Type	Update	Change
github.com/openstack-k8s-operators/designate-operator/api	require	digest	`b02b9ed` -> `07cf331`
github.com/openstack-k8s-operators/glance-operator/api	require	digest	`4842c7d` -> `4f93d5b`
github.com/openstack-k8s-operators/infra-operator/apis	require	digest	`4a62aed` -> `eb287d5`
github.com/openstack-k8s-operators/ironic-operator/api	require	digest	`ea88986` -> `819a842`
github.com/openstack-k8s-operators/keystone-operator/api	require	digest	`dbe5adf` -> `10f5f7e`
github.com/openstack-k8s-operators/lib-common/modules/ansible	require	digest	`f95cd29` -> `5a4c5f4`
github.com/openstack-k8s-operators/lib-common/modules/certmanager	require	digest	`f95cd29` -> `5a4c5f4`
github.com/openstack-k8s-operators/lib-common/modules/common	require	digest	`f95cd29` -> `5a4c5f4`
github.com/openstack-k8s-operators/lib-common/modules/openstack	indirect	digest	`f95cd29` -> `5a4c5f4`
github.com/openstack-k8s-operators/lib-common/modules/storage	require	digest	`f95cd29` -> `5a4c5f4`
github.com/openstack-k8s-operators/lib-common/modules/test	require	digest	`f95cd29` -> `5a4c5f4`
github.com/openstack-k8s-operators/octavia-operator/api	require	digest	`704dfe6` -> `8386f96`
github.com/openstack-k8s-operators/ovn-operator/api	require	digest	`4975648` -> `4e4066d`
github.com/openstack-k8s-operators/placement-operator/api	require	digest	`7916183` -> `2af0cee`

Configuration

📅 Schedule: Branch creation - "every weekend" in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

openstack-k8s-ci-robot · 2025-04-05T04:43:39Z

ℹ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

1 additional dependency was updated

Details:

Package	Change
`github.com/k8snetworkplumbingwg/network-attachment-definition-client`	`v1.7.5` -> `v1.7.6`

bshephar · 2025-04-06T09:06:12Z

/test precommit-check

stuggi · 2025-04-06T09:29:22Z

@fmount fyi, should we add this?

ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol must set x-kubernetes-list-type

fmount · 2025-04-06T13:35:21Z

@fmount fyi, should we add this?

ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol must set x-kubernetes-list-type

@stuggi in theory we can add the annotations as per the crd-schema-checker requirements. We can skip or override the check in this patch to not block it, in the meantime I'll prepare the lib-common PR (based on the failing log) and the next bump we'll take them.

fmount · 2025-04-07T07:01:09Z

@stuggi I think that we should track this as a bug that we might want to solve, but currently skip the check and merge this patch.
I'm saying this because in lib-common/modules/storage we import a bunch of volumeSources [1], the same way it is defined in k8s [2], but the most inner level doesn't define these annotations, and it might result problematic for us to unpack that struct just for the purpose of adding those annotations (I don't see a real advantage).

ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].iscsi.portals must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].secret.items must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].downwardAPI.items must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].cephfs.monitors must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].configMap.items must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].projected.sources must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].projected.sources[*].clusterTrustBundle.labelSelector.matchExpressions must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].projected.sources[*].clusterTrustBundle.labelSelector.matchExpressions[*].values must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].projected.sources[*].configMap.items must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].projected.sources[*].downwardAPI.items must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].projected.sources[*].secret.items must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].fc.targetWWNs must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].fc.wwids must set x-kubernetes-list-type

For this reason, while we can add them where we can if this is the agreement, I propose to update the crd-schema-checker [3] and skip ListsMustHaveSSATags. We can still track this as a bug in [4] and investigate a long term fix for this one.

[1] https://github.com/openstack-k8s-operators/lib-common/blob/main/modules/storage/storage.go#L48
[2] https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/types.go#L232
[3] https://github.com/openstack-k8s-operators/openstack-operator/blob/main/hack/crd-schema-checker.sh#L6
[4] https://issues.redhat.com/browse/OSPRH-12254

stuggi · 2025-04-07T08:27:36Z

@stuggi I think that we should track this as a bug that we might want to solve, but currently skip the check and merge this patch. I'm saying this because in lib-common/modules/storage we import a bunch of volumeSources [1], the same way it is defined in k8s [2], but the most inner level doesn't define these annotations, and it might result problematic for us to unpack that struct just for the purpose of adding those annotations (I don't see a real advantage).

ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].iscsi.portals must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].secret.items must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].downwardAPI.items must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].cephfs.monitors must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].configMap.items must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].projected.sources must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].projected.sources[*].clusterTrustBundle.labelSelector.matchExpressions must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].projected.sources[*].clusterTrustBundle.labelSelector.matchExpressions[*].values must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].projected.sources[*].configMap.items must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].projected.sources[*].downwardAPI.items must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].projected.sources[*].secret.items must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].fc.targetWWNs must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol[*].volumes[*].fc.wwids must set x-kubernetes-list-type

For this reason, while we can add them where we can if this is the agreement, I propose to update the crd-schema-checker [3] and skip ListsMustHaveSSATags. We can still track this as a bug in [4] and investigate a long term fix for this one.

[1] https://github.com/openstack-k8s-operators/lib-common/blob/main/modules/storage/storage.go#L48 [2] https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/types.go#L232 [3] https://github.com/openstack-k8s-operators/openstack-operator/blob/main/hack/crd-schema-checker.sh#L6 [4] https://issues.redhat.com/browse/OSPRH-12254

ack, sounds good to me

stuggi · 2025-04-07T08:28:00Z

/override ci/prow/precommit-check

openshift-ci · 2025-04-07T08:28:04Z

@stuggi: Overrode contexts on behalf of stuggi: ci/prow/precommit-check

In response to this:

/override ci/prow/precommit-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

stuggi

/lgtm

openshift-ci · 2025-04-07T08:28:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openstack-k8s-ci-robot, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [stuggi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot requested review from rebtoor and slagle April 5, 2025 04:43

openstack-k8s-ci-robot force-pushed the renovate/main-openstack-k8s-operators branch from e912816 to f6293b5 Compare April 6, 2025 09:44

Update openstack-k8s-operators

e3747ab

openstack-k8s-ci-robot force-pushed the renovate/main-openstack-k8s-operators branch from f6293b5 to e3747ab Compare April 6, 2025 11:17

fmount mentioned this pull request Apr 6, 2025

Fix ListsMustHaveSSATags raised by crd-schema-checker openstack-k8s-operators/lib-common#617

Open

fmount mentioned this pull request Apr 7, 2025

Temporarily skip ListMustHaveSSATags #1398

Closed

stuggi approved these changes Apr 7, 2025

View reviewed changes

openshift-ci bot assigned stuggi Apr 7, 2025

openshift-ci bot added the lgtm label Apr 7, 2025

openshift-ci bot added the approved label Apr 7, 2025

openshift-merge-bot bot merged commit d648626 into main Apr 7, 2025
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update openstack-k8s-operators (main) #1395

Update openstack-k8s-operators (main) #1395

Uh oh!

openstack-k8s-ci-robot commented Apr 5, 2025 •

edited

Loading

Uh oh!

openstack-k8s-ci-robot commented Apr 5, 2025

Uh oh!

bshephar commented Apr 6, 2025

Uh oh!

stuggi commented Apr 6, 2025

Uh oh!

fmount commented Apr 6, 2025

Uh oh!

fmount commented Apr 7, 2025 •

edited

Loading

Uh oh!

stuggi commented Apr 7, 2025

Uh oh!

stuggi commented Apr 7, 2025

Uh oh!

openshift-ci bot commented Apr 7, 2025

Uh oh!

stuggi left a comment

Uh oh!

openshift-ci bot commented Apr 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Update openstack-k8s-operators (main) #1395

Update openstack-k8s-operators (main) #1395

Uh oh!

Conversation

openstack-k8s-ci-robot commented Apr 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Configuration

Uh oh!

openstack-k8s-ci-robot commented Apr 5, 2025

ℹ Artifact update notice

File name: go.mod

Uh oh!

bshephar commented Apr 6, 2025

Uh oh!

stuggi commented Apr 6, 2025

Uh oh!

fmount commented Apr 6, 2025

Uh oh!

fmount commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stuggi commented Apr 7, 2025

Uh oh!

stuggi commented Apr 7, 2025

Uh oh!

openshift-ci bot commented Apr 7, 2025

Uh oh!

stuggi left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Apr 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openstack-k8s-ci-robot commented Apr 5, 2025 •

edited

Loading

fmount commented Apr 7, 2025 •

edited

Loading