Skip to content

Conversation

@ratailor
Copy link
Contributor

@ratailor ratailor commented Aug 25, 2025

This commit adds support for restructured multi-group nova-operator which includes placement-operator functionality merged into it.

The nova-operator changes include:

  • Restructuring from single-group to multi-group operator
  • Moving Nova APIs to apis/nova/v1beta1/ namespace
  • Adding Placement APIs under apis/placement/v1beta1/
  • Controllers organized under controllers/nova and controllers/placement
  • Complete placement-operator codebase integration including:
    • Placement API definitions and webhooks
    • Placement controller and deployment logic
    • Configuration templates and RBAC
    • Functional and KUTTL tests

This enables unified management of both Nova and Placement services within in a single operator.

Depends-On: openstack-k8s-operators/nova-operator#996

Commit message assisted by: claude-4-sonnet
Closes: OSPRH-14957

@openshift-ci openshift-ci bot requested review from fultonj and olliewalsh August 25, 2025 10:51
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ratailor
Once this PR has been reviewed and has the lgtm label, please assign slagle for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ead592fbc27844349411957a55792429

openstack-k8s-operators-content-provider FAILURE in 7m 10s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/502667131f58431e9b45dc3db9884380

openstack-k8s-operators-content-provider FAILURE in 6m 48s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6ab785f4144940728ff337601c0e1484

openstack-k8s-operators-content-provider FAILURE in 5m 52s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/794aacb645eb4e6cafeadb65d06a6685

openstack-k8s-operators-content-provider FAILURE in 12m 12s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/dd76b5422bae4dd18a4e0c6a7dc505f0

openstack-k8s-operators-content-provider FAILURE in 13m 47s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

This commit adds support for restructured multi-group
nova-operator which includes placement-operator functionality
merged into it.

The nova-operator changes include:
- Restructuring from single-group to multi-group operator
- Moving Nova APIs to apis/nova/v1beta1/ namespace
- Adding Placement APIs under apis/placement/v1beta1/
- Controllers organized under controllers/nova and controllers/placement
- Complete placement-operator codebase integration including:
  * Placement API definitions and webhooks
  * Placement controller and deployment logic
  * Configuration templates and RBAC
  * Functional and KUTTL tests

This enables unified management of both Nova and Placement
services within in a single operator.

Depends-On: openstack-k8s-operators/nova-operator#996

Commit message assisted by: claude-4-sonnet
Closes: OSPRH-14957
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ab59a9955c444bbe9d293d09e14895e3

openstack-k8s-operators-content-provider FAILURE in 12m 26s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2025

@ratailor: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/precommit-check c003fc9 link true /test precommit-check
ci/prow/openstack-operator-build-deploy-kuttl-4-18 c003fc9 link true /test openstack-operator-build-deploy-kuttl-4-18
ci/prow/openstack-operator-build-deploy-kuttl c003fc9 link true /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dprince
Copy link
Contributor

dprince commented Aug 28, 2025

As part of this effort I think we will need to add some cleanup code to the controllers/operator/openstack_controller.go code to ensure the old placement-operator specific RBAC, certificates, etc. are properly cleaned up on upgrade via the initialization resource.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants