-
Notifications
You must be signed in to change notification settings - Fork 63
Remove double slash from paths #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove double slash from paths #342
Conversation
After run_tempest.sh refactor some paths now have double slash in them by doing incorrect path combination. This patch removes specific slashes that are causing this problem.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kstrenkova The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick antelope |
|
@kstrenkova: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
sdatko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, it that a problem somewhere? I know in some logged outputs, but paths with double slashes are perfectly valid and usually I just prefer that in variables, because then both ${DIR}${FILE} is fine in usage, as well as ${DIR}/${FILE} (i.e. so we do not need to worry about convention people took).
Hi :D I know it is not a technical problem, but to me it makes more sense to have it consistent in the file. I removed the slashes that are extra at the end of variable definitions everywhere. So I expect someone who modifies the code to follow that pattern. In the end we have both clean path and a pattern for new users. |
After run_tempest.sh refactor some paths now have double slash in them by doing incorrect path combination. This patch removes specific slashes that are causing this problem.