Skip to content

Conversation

@kstrenkova
Copy link
Contributor

After run_tempest.sh refactor some paths now have double slash in them by doing incorrect path combination. This patch removes specific slashes that are causing this problem.

After run_tempest.sh refactor some paths now have double slash in
them by doing incorrect path combination. This patch removes
specific slashes that are causing this problem.
@openshift-ci openshift-ci bot requested review from fultonj and olliewalsh October 15, 2025 10:02
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kstrenkova
Once this PR has been reviewed and has the lgtm label, please assign slawqo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kstrenkova kstrenkova requested a review from sdatko October 15, 2025 10:04
@kstrenkova
Copy link
Contributor Author

/cherry-pick antelope

@openshift-cherrypick-robot

@kstrenkova: once the present PR merges, I will cherry-pick it on top of antelope in a new PR and assign it to you.

In response to this:

/cherry-pick antelope

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kstrenkova kstrenkova requested a review from rabi October 16, 2025 12:31
Copy link
Contributor

@sdatko sdatko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, it that a problem somewhere? I know in some logged outputs, but paths with double slashes are perfectly valid and usually I just prefer that in variables, because then both ${DIR}${FILE} is fine in usage, as well as ${DIR}/${FILE} (i.e. so we do not need to worry about convention people took).

@kstrenkova
Copy link
Contributor Author

Out of curiosity, it that a problem somewhere? I know in some logged outputs, but paths with double slashes are perfectly valid and usually I just prefer that in variables, because then both ${DIR}${FILE} is fine in usage, as well as ${DIR}/${FILE} (i.e. so we do not need to worry about convention people took).

Hi :D I know it is not a technical problem, but to me it makes more sense to have it consistent in the file. I removed the slashes that are extra at the end of variable definitions everywhere. So I expect someone who modifies the code to follow that pattern. In the end we have both clean path and a pattern for new users.

@kstrenkova kstrenkova requested a review from sdatko October 29, 2025 11:18
@kstrenkova kstrenkova requested review from fultonj and rabi and removed request for fultonj and rabi November 11, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants